Bug 199317

Summary: Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebKit Misc.Assignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bfulgham, cgarcia, commit-queue, don.olmstead, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2019-06-28 05:30:09 PDT
While IconDatabase and all code using it was removed, ENABLE_ICONDATABASE macro still exists
Attachments
Patch (72.95 KB, patch)
2019-06-28 05:42 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2019-06-28 05:42:24 PDT
Created attachment 373108 [details] Patch
Konstantin Tokarev
Comment 2 2019-06-28 05:58:52 PDT
GTK folks: please check if urlIcon.png is really not needed anywhere. Apple folks: please review Xcode changes and change in Source/WebKitLegacy/mac/WebView/WebView.mm Windows folks: please review changes in vsprops
Michael Catanzaro
Comment 3 2019-06-28 08:22:34 PDT
Comment on attachment 373108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373108&action=review > Source/WebKit/PlatformGTK.cmake:-529 > - " <file alias=\"images/urlIcon\">urlIcon.png</file>\n" A quick grep suggests this is indeed stale. Goodbye! > Source/WebKitLegacy/mac/WebView/WebView.mm:3325 > -#if ENABLE(ICONDATABASE) > +#if PLATFORM(MAC) OK, this matches the #if !TARGET_OS_IPHONE in WebFrameLoadDelegate.h. Good.
WebKit Commit Bot
Comment 4 2019-06-28 09:00:23 PDT
Comment on attachment 373108 [details] Patch Clearing flags on attachment: 373108 Committed r246925: <https://trac.webkit.org/changeset/246925>
WebKit Commit Bot
Comment 5 2019-06-28 09:00:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-06-28 09:04:57 PDT
<rdar://problem/52333874>
Note You need to log in before you can comment on or make changes to this bug.