Bug 199310

Summary: -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, bweinstein, commit-queue, dino, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix non-iOS builds none

Wenson Hsieh
Reported 2019-06-27 21:19:32 PDT
<rdar://problem/52292137>
Attachments
Patch (11.42 KB, patch)
2019-06-27 21:30 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix non-iOS builds (11.43 KB, patch)
2019-06-27 21:45 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-06-27 21:30:42 PDT
Created attachment 373080 [details] Patch
Wenson Hsieh
Comment 2 2019-06-27 21:45:57 PDT
Created attachment 373082 [details] Fix non-iOS builds
Megan Gardner
Comment 3 2019-06-28 07:15:50 PDT
Comment on attachment 373082 [details] Fix non-iOS builds View in context: https://bugs.webkit.org/attachment.cgi?id=373082&action=review > Source/WebKit/UIProcess/WebPageProxy.h:1379 > I don’t see anywhere in this patch that this is set. What am I missing? Also, holy long name Batman, but I don’t have a suggestion to what to shorten it to...
Wenson Hsieh
Comment 4 2019-06-28 07:18:18 PDT
(In reply to Megan Gardner from comment #3) > Comment on attachment 373082 [details] > Fix non-iOS builds > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373082&action=review > > > Source/WebKit/UIProcess/WebPageProxy.h:1379 > > > > I don’t see anywhere in this patch that this is set. What am I missing? > Also, holy long name Batman, but I don’t have a suggestion to what to > shorten it to... Thanks for the review! This flag already existed (and was set/unset) beforehand; this patch just exposes a getter on WebPageProxy so that it can be consulted in WKContentView.
WebKit Commit Bot
Comment 5 2019-06-28 07:48:58 PDT
Comment on attachment 373082 [details] Fix non-iOS builds Clearing flags on attachment: 373082 Committed r246924: <https://trac.webkit.org/changeset/246924>
WebKit Commit Bot
Comment 6 2019-06-28 07:49:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.