Bug 199307

Summary: Web Inspector: support `console.screenshot` with dataURL strings
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 199308    
Bug Blocks: 200747    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2019-06-27 19:45:19 PDT
.
Attachments
Patch (4.80 KB, patch)
2019-06-27 22:51 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (13.61 KB, patch)
2019-08-14 12:50 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-06-27 22:51:18 PDT
Created attachment 373087 [details] Patch
Joseph Pecoraro
Comment 2 2019-07-22 13:18:46 PDT
Comment on attachment 373087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373087&action=review r=me > Source/WebCore/page/PageConsoleClient.cpp:315 > + if (dataURL.isEmpty() || dataURL == "data:,") { Seems like a weird case check for just "data:,". Someone could do: `data:image/png," and bypass this.
Devin Rousso
Comment 3 2019-07-24 16:49:24 PDT
I'm going to hold off on this a bit, as I think we should be a bit smarter about what is and isn't a dataURL.
Devin Rousso
Comment 4 2019-08-14 12:50:46 PDT
Created attachment 376297 [details] Patch
WebKit Commit Bot
Comment 5 2019-08-14 14:59:30 PDT
Comment on attachment 376297 [details] Patch Clearing flags on attachment: 376297 Committed r248688: <https://trac.webkit.org/changeset/248688>
WebKit Commit Bot
Comment 6 2019-08-14 14:59:31 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-08-14 15:00:20 PDT
<rdar://problem/54320656>
Note You need to log in before you can comment on or make changes to this bug.