Summary: | Layout Test fast/parser/parser-yield-timing.html is flaky | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Russell Epstein <repstein> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, ggaren, mark.lam, ryanhaddad, thorton, tsavell, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Russell Epstein
2019-06-27 11:45:06 PDT
Created attachment 373040 [details]
Update TestExpectations
Comment on attachment 373040 [details] Update TestExpectations Clearing flags on attachment: 373040 Committed r246898: <https://trac.webkit.org/changeset/246898> Created attachment 373048 [details]
Patch
Comment on attachment 373048 [details] Patch Clearing flags on attachment: 373048 Committed r246904: <https://trac.webkit.org/changeset/246904> All reviewed patches have been landed. Closing bug. Had an offline discussion with thorton. Discussed that it may be better to increase the test tolerance rather than marking the test as flaky. Increased test tolerance from ±300ms to ±400ms to reduce noise. Updated fast/parser/parser-yield-timing-expected.txt to reflect this change. Removed expected failure from TestExpectations. https://trac.webkit.org/changeset/246904/webkit (In reply to WebKit Commit Bot from comment #5) > Comment on attachment 373048 [details] > Patch > > Clearing flags on attachment: 373048 > > Committed r246904: <https://trac.webkit.org/changeset/246904> |