Bug 199244

Summary: [Win] MiniBrowser should make better font choices
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, don.olmstead, Hironori.Fujii, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Screenshot
none
Patch for landing none

Description Ross Kirsling 2019-06-26 16:46:50 PDT
[Win] MiniBrowser should make better font choices
Comment 1 Ross Kirsling 2019-06-26 16:47:36 PDT
Created attachment 372966 [details]
Patch
Comment 2 Ross Kirsling 2019-06-26 16:50:05 PDT
Created attachment 372967 [details]
Screenshot
Comment 3 Ross Kirsling 2019-06-26 16:51:38 PDT
I felt like improving the URL bar font alone would go a long way in making MiniBrowser feel more usable on Windows. ;)
Comment 4 Brent Fulgham 2019-06-26 16:54:04 PDT
Comment on attachment 372966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372966&action=review

r=me

> Tools/MiniBrowser/win/MiniBrowserLib.rc:147
> +    LTEXT           "MiniBrowser Version 1.0",IDC_STATIC,49,10,119,8

I think this might deserve at least a 1.1!  :-)
Comment 5 Ross Kirsling 2019-06-26 16:55:14 PDT
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 372966 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372966&action=review
> 
> r=me
> 
> > Tools/MiniBrowser/win/MiniBrowserLib.rc:147
> > +    LTEXT           "MiniBrowser Version 1.0",IDC_STATIC,49,10,119,8
> 
> I think this might deserve at least a 1.1!  :-)

Hah! Let's go for it.
Comment 6 Ross Kirsling 2019-06-26 16:58:22 PDT
Created attachment 372969 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-06-26 17:34:56 PDT
Comment on attachment 372969 [details]
Patch for landing

Clearing flags on attachment: 372969

Committed r246861: <https://trac.webkit.org/changeset/246861>
Comment 8 WebKit Commit Bot 2019-06-26 17:34:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-06-26 17:35:17 PDT
<rdar://problem/52221365>