Bug 199242

Summary: Layout Test http/tests/performance/performance-resource-timing-resourcetimingbufferfull-shrinking-buffer-crash.html is failing
Product: WebKit Reporter: Russell Epstein <repstein>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: ryanhaddad, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Update TestExpectations none

Description Russell Epstein 2019-06-26 16:10:54 PDT
The following layout test is failing on Debug Mac WK1
http/tests/performance/performance-resource-timing-resourcetimingbufferfull-shrinking-buffer-crash.html

Steps to Reproduce:

When attempting to reproduce the issue locally, the output of the tests was fairly variable. Switched to testing on a relevant bot for environmental consistency.

The test is failing at the tip of tree (r246832) all the way back to as early as r228050 with the same layout-test-results diff.

Attempted to test as far back as r227926, where the test was introduced, but no builds were available beyond r228050.


Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fperformance%2Fperformance-resource-timing-resourcetimingbufferfull-shrinking-buffer-crash.html

Diff:

--- /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/http/tests/performance/performance-resource-timing-resourcetimingbufferfull-shrinking-buffer-crash-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/http/tests/performance/performance-resource-timing-resourcetimingbufferfull-shrinking-buffer-crash-actual.txt
@@ -7,25 +7,25 @@
 PASS performance.getEntriesByType("resource").length is 0
 performance.setResourceTimingBufferSize(2)
 fetchImages(3).then(checkInitialState)
-PASS originalResources = performance.getEntriesByType("resource"); originalResources.length is 2
+FAIL originalResources = performance.getEntriesByType("resource"); originalResources.length should be 2. Was 1.
 PASS originalResources[0].initiatorType is "fetch"
-PASS new URL(originalResources[0].name).search is "?resource=0"
-PASS originalResources[1].initiatorType is "fetch"
-PASS new URL(originalResources[1].name).search is "?resource=1"
+FAIL new URL(originalResources[0].name).search should be ?resource=0. Was ?resource=1.
+FAIL originalResources[1].initiatorType should be fetch. Threw exception TypeError: undefined is not an object (evaluating 'originalResources[1].initiatorType')
+FAIL new URL(originalResources[1].name).search should be ?resource=1. Threw exception TypeError: undefined is not an object (evaluating 'originalResources[1].name')
 PASS resourcetimingbufferfullEventCount is 0
 
 Inside resourcetimingbufferfull 1
 performance.setResourceTimingBufferSize(1)
 PASS resourcesAfterShrinkingBuffer = performance.getEntriesByType("resource"); resourcesAfterShrinkingBuffer.length is 2
 PASS resourcesAfterShrinkingBuffer[0] is originalResources[0]
-PASS resourcesAfterShrinkingBuffer[1] is originalResources[1]
+FAIL resourcesAfterShrinkingBuffer[1] should be undefined (of type undefined). Was [object PerformanceResourceTiming] (of type object).
 PASS performance.clearResourceTimings(); performance.getEntriesByType("resource").length is 0
 
 After resourcetimingbufferfull
 PASS resourcetimingbufferfullEventCount is 1
 PASS resourcesAfterClearing = performance.getEntriesByType("resource"); resourcesAfterClearing.length is 1
 PASS resourcesAfterClearing[0].initiatorType is "fetch"
-PASS new URL(resourcesAfterClearing[0].name).search is "?resource=2"
+FAIL new URL(resourcesAfterClearing[0].name).search should be ?resource=2. Was ?resource=0.
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Russell Epstein 2019-06-26 16:18:21 PDT
Created attachment 372964 [details]
Update TestExpectations
Comment 2 Radar WebKit Bug Importer 2019-06-26 16:19:23 PDT
<rdar://problem/52217225>
Comment 3 Truitt Savell 2019-06-26 16:20:50 PDT
Comment on attachment 372964 [details]
Update TestExpectations

Clearing flags on attachment: 372964

Committed r246854: <https://trac.webkit.org/changeset/246854>
Comment 4 Russell Epstein 2019-06-26 16:30:58 PDT
Marking test as flaky until issue is resolved

(In reply to Truitt Savell from comment #3)
> Comment on attachment 372964 [details]
> Update TestExpectations
> 
> Clearing flags on attachment: 372964
> 
> Committed r246854: <https://trac.webkit.org/changeset/246854>