Bug 199230

Summary: testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, ews-watchlist, fujii.hironori, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
patch
none
Patch none

Alex Christensen
Reported 2019-06-26 13:15:27 PDT
testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
Attachments
Patch (58.46 KB, patch)
2019-06-26 13:19 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (57.56 KB, patch)
2019-06-26 13:50 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (57.43 KB, patch)
2019-06-26 14:15 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
patch (57.45 KB, patch)
2019-06-26 14:24 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (57.62 KB, patch)
2019-06-26 15:47 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-06-26 13:19:55 PDT
Created attachment 372943 [details] Patch
Alex Christensen
Comment 2 2019-06-26 13:50:38 PDT
Created attachment 372948 [details] Patch
EWS Watchlist
Comment 3 2019-06-26 13:54:04 PDT
Attachment 372948 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/API/C/WKMessageListener.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 4 2019-06-26 14:15:12 PDT
Created attachment 372950 [details] Patch
EWS Watchlist
Comment 5 2019-06-26 14:17:06 PDT
Attachment 372950 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/API/C/WKMessageListener.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 6 2019-06-26 14:24:13 PDT
Created attachment 372951 [details] patch
EWS Watchlist
Comment 7 2019-06-26 14:26:21 PDT
Attachment 372951 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/API/C/WKMessageListener.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 8 2019-06-26 14:30:50 PDT
I have no idea why linux doesn't like this. Michael?
Alex Christensen
Comment 9 2019-06-26 15:47:34 PDT
Created attachment 372958 [details] Patch
EWS Watchlist
Comment 10 2019-06-26 15:49:09 PDT
Attachment 372958 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/API/C/WKMessageListener.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 11 2019-06-26 16:30:25 PDT
Comment on attachment 372958 [details] Patch Clearing flags on attachment: 372958 Committed r246856: <https://trac.webkit.org/changeset/246856>
WebKit Commit Bot
Comment 12 2019-06-26 16:30:28 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2019-06-26 16:31:17 PDT
<rdar://problem/52217933>
Fujii Hironori
Comment 14 2019-06-26 21:48:06 PDT
Committed r246870: <https://trac.webkit.org/changeset/246870>
Note You need to log in before you can comment on or make changes to this bug.