Bug 199230

Summary: testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, ews-watchlist, Hironori.Fujii, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
patch
none
Patch none

Description Alex Christensen 2019-06-26 13:15:27 PDT 
testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
Comment 1 Alex Christensen 2019-06-26 13:19:55 PDT 
Created attachment 372943 [details]
Patch
Comment 2 Alex Christensen 2019-06-26 13:50:38 PDT 
Created attachment 372948 [details]
Patch
Comment 3 EWS Watchlist 2019-06-26 13:54:04 PDT 
Attachment 372948 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/API/C/WKMessageListener.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alex Christensen 2019-06-26 14:15:12 PDT 
Created attachment 372950 [details]
Patch
Comment 5 EWS Watchlist 2019-06-26 14:17:06 PDT 
Attachment 372950 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/API/C/WKMessageListener.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Alex Christensen 2019-06-26 14:24:13 PDT 
Created attachment 372951 [details]
patch
Comment 7 EWS Watchlist 2019-06-26 14:26:21 PDT 
Attachment 372951 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/API/C/WKMessageListener.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Alex Christensen 2019-06-26 14:30:50 PDT 
I have no idea why linux doesn't like this.  Michael?
Comment 9 Alex Christensen 2019-06-26 15:47:34 PDT 
Created attachment 372958 [details]
Patch
Comment 10 EWS Watchlist 2019-06-26 15:49:09 PDT 
Attachment 372958 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/API/C/WKMessageListener.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 WebKit Commit Bot 2019-06-26 16:30:25 PDT 
Comment on attachment 372958 [details]
Patch

Clearing flags on attachment: 372958

Committed r246856: <https://trac.webkit.org/changeset/246856>
Comment 12 WebKit Commit Bot 2019-06-26 16:30:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2019-06-26 16:31:17 PDT 
<rdar://problem/52217933>
Comment 14 Fujii Hironori 2019-06-26 21:48:06 PDT 
Committed r246870: <https://trac.webkit.org/changeset/246870>