Bug 199222

Summary: [iOS Scrolling] Propagate scrolls to non-nested UIScrollViews
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: ScrollingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
test case
none
test with more nested scrollers
none
patch none

Antti Koivisto
Reported 2019-06-26 04:25:39 PDT
With help of some UIKit SPIs.
Attachments
WIP (3.96 KB, patch)
2019-06-26 04:27 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
test case (641 bytes, text/html)
2019-06-26 04:28 PDT, Antti Koivisto 		no flags
Details
test with more nested scrollers (995 bytes, text/html)
2019-06-27 06:43 PDT, Antti Koivisto 		no flags
Details
patch (6.32 KB, patch)
2019-06-28 04:31 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-06-26 04:27:50 PDT
Created attachment 372913 [details] WIP
Antti Koivisto
Comment 2 2019-06-26 04:28:15 PDT
Created attachment 372914 [details] test case
Antti Koivisto
Comment 3 2019-06-27 06:43:18 PDT
Created attachment 373030 [details] test with more nested scrollers
Antti Koivisto
Comment 4 2019-06-28 04:31:45 PDT
Created attachment 373104 [details] patch
Simon Fraser (smfr)
Comment 5 2019-06-28 09:15:08 PDT
Comment on attachment 373104 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=373104&action=review > Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:141 > + if (auto* nonAncestorScrollingNode = host.nodeForID(node->relatedScrollContainerIDs()[0])) I'm having a hard time convincing myself that using relatedScrollContainerIDs()[0] is correct. What does it mean to have more than one? What is the order?
Antti Koivisto
Comment 6 2019-06-28 09:41:49 PDT
> I'm having a hard time convincing myself that using > relatedScrollContainerIDs()[0] is correct. What does it mean to have more > than one? What is the order? Would knowing that you wrote the code that sets it be help? :) It is simply the layer tree counterpart of ScrollingTreeOverflowScrollProxyNode::m_overflowScrollingNodeID. Having Moves and Stationary cases in a single vector matches the old design where PositionedNode handled both cases. It should really be refactored into two separate variables, matching PositionedNode split.
WebKit Commit Bot
Comment 7 2019-06-28 10:12:33 PDT
Comment on attachment 373104 [details] patch Clearing flags on attachment: 373104 Committed r246926: <https://trac.webkit.org/changeset/246926>
WebKit Commit Bot
Comment 8 2019-06-28 10:12:34 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-06-28 10:17:49 PDT
<rdar://problem/52338107>
Antti Koivisto
Comment 10 2019-06-28 10:25:31 PDT
<rdar://problem/49720738>
Note You need to log in before you can comment on or make changes to this bug.