Bug 199214

Summary: CagedPtr doesn't merge PAC bits back into the resulting caged pointer.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Keith Miller 2019-06-25 18:02:07 PDT 
CagedPtr doesn't merge PAC bits back into the resulting caged pointer.
Comment 1 Keith Miller 2019-06-25 18:04:00 PDT 
Created attachment 372887 [details]
Patch
Comment 2 Keith Miller 2019-06-25 18:19:58 PDT 
Created attachment 372888 [details]
Patch
Comment 3 EWS Watchlist 2019-06-25 18:22:42 PDT 
Attachment 372888 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/CagedPtr.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Yusuke Suzuki 2019-06-25 18:48:36 PDT 
Comment on attachment 372888 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2019-06-25 19:25:25 PDT 
Comment on attachment 372888 [details]
Patch

Clearing flags on attachment: 372888

Committed r246827: <https://trac.webkit.org/changeset/246827>
Comment 6 WebKit Commit Bot 2019-06-25 19:25:26 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-06-26 16:47:59 PDT 
<rdar://problem/52218882>