Summary: | [Win] MiniBrowser should default to webkit.org | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||
Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, don.olmstead, Hironori.Fujii, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ross Kirsling
2019-06-25 13:42:02 PDT
Created attachment 372858 [details]
Patch
We should have done this long ago! The start page is aiming to test WebKit api. You can remove the test code, too. (In reply to Fujii Hironori from comment #3) > The start page is aiming to test WebKit api. You can remove the test code, > too. Whoops, thanks for that. Will do. Created attachment 372868 [details]
Patch for landing
Comment on attachment 372868 [details]
Patch for landing
My bad. The test code seems removed already.
Comment on attachment 372868 [details] Patch for landing Clearing flags on attachment: 372868 Committed r246814: <https://trac.webkit.org/changeset/246814> All reviewed patches have been landed. Closing bug. (In reply to Fujii Hironori from comment #6) > My bad. The test code seems removed already. Oh, it still is in Tools/MiniBrowser/win/MiniBrowserWebHost.cpp. It is SimpleEventListener. This code became dead. Could you remove this? (In reply to Fujii Hironori from comment #9) > (In reply to Fujii Hironori from comment #6) > > My bad. The test code seems removed already. > > Oh, it still is in Tools/MiniBrowser/win/MiniBrowserWebHost.cpp. > It is SimpleEventListener. This code became dead. Could you remove this? Patch submitted @ bug 199233. |