Bug 199201

Summary: [Win] MiniBrowser should default to webkit.org
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, don.olmstead, fujii.hironori, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Ross Kirsling
Reported 2019-06-25 13:42:02 PDT
[Win] MiniBrowser should default to webkit.org
Attachments
Patch (3.07 KB, patch)
2019-06-25 13:44 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.36 KB, patch)
2019-06-25 15:41 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2019-06-25 13:44:37 PDT
Created attachment 372858 [details] Patch
Brent Fulgham
Comment 2 2019-06-25 14:26:48 PDT
We should have done this long ago!
Fujii Hironori
Comment 3 2019-06-25 15:13:12 PDT
The start page is aiming to test WebKit api. You can remove the test code, too.
Ross Kirsling
Comment 4 2019-06-25 15:14:49 PDT
(In reply to Fujii Hironori from comment #3) > The start page is aiming to test WebKit api. You can remove the test code, > too. Whoops, thanks for that. Will do.
Ross Kirsling
Comment 5 2019-06-25 15:41:06 PDT
Created attachment 372868 [details] Patch for landing
Fujii Hironori
Comment 6 2019-06-25 15:58:43 PDT
Comment on attachment 372868 [details] Patch for landing My bad. The test code seems removed already.
WebKit Commit Bot
Comment 7 2019-06-25 16:24:36 PDT
Comment on attachment 372868 [details] Patch for landing Clearing flags on attachment: 372868 Committed r246814: <https://trac.webkit.org/changeset/246814>
WebKit Commit Bot
Comment 8 2019-06-25 16:24:39 PDT
All reviewed patches have been landed. Closing bug.
Fujii Hironori
Comment 9 2019-06-25 18:50:40 PDT
(In reply to Fujii Hironori from comment #6) > My bad. The test code seems removed already. Oh, it still is in Tools/MiniBrowser/win/MiniBrowserWebHost.cpp. It is SimpleEventListener. This code became dead. Could you remove this?
Ross Kirsling
Comment 10 2019-06-26 13:47:34 PDT
(In reply to Fujii Hironori from comment #9) > (In reply to Fujii Hironori from comment #6) > > My bad. The test code seems removed already. > > Oh, it still is in Tools/MiniBrowser/win/MiniBrowserWebHost.cpp. > It is SimpleEventListener. This code became dead. Could you remove this? Patch submitted @ bug 199233.
Radar WebKit Bug Importer
Comment 11 2019-06-26 16:11:22 PDT
<rdar://problem/52216674>
Radar WebKit Bug Importer
Comment 12 2019-06-26 16:11:23 PDT
<rdar://problem/52216675>
Note You need to log in before you can comment on or make changes to this bug.