Bug 199201

Summary: [Win] MiniBrowser should default to webkit.org
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, don.olmstead, Hironori.Fujii, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Ross Kirsling 2019-06-25 13:42:02 PDT
[Win] MiniBrowser should default to webkit.org
Comment 1 Ross Kirsling 2019-06-25 13:44:37 PDT
Created attachment 372858 [details]
Patch
Comment 2 Brent Fulgham 2019-06-25 14:26:48 PDT
We should have done this long ago!
Comment 3 Fujii Hironori 2019-06-25 15:13:12 PDT
The start page is aiming to test WebKit api. You can remove the test code, too.
Comment 4 Ross Kirsling 2019-06-25 15:14:49 PDT
(In reply to Fujii Hironori from comment #3)
> The start page is aiming to test WebKit api. You can remove the test code,
> too.

Whoops, thanks for that. Will do.
Comment 5 Ross Kirsling 2019-06-25 15:41:06 PDT
Created attachment 372868 [details]
Patch for landing
Comment 6 Fujii Hironori 2019-06-25 15:58:43 PDT
Comment on attachment 372868 [details]
Patch for landing

My bad. The test code seems removed already.
Comment 7 WebKit Commit Bot 2019-06-25 16:24:36 PDT
Comment on attachment 372868 [details]
Patch for landing

Clearing flags on attachment: 372868

Committed r246814: <https://trac.webkit.org/changeset/246814>
Comment 8 WebKit Commit Bot 2019-06-25 16:24:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Fujii Hironori 2019-06-25 18:50:40 PDT
(In reply to Fujii Hironori from comment #6)
> My bad. The test code seems removed already.

Oh, it still is in Tools/MiniBrowser/win/MiniBrowserWebHost.cpp.
It is SimpleEventListener. This code became dead. Could you remove this?
Comment 10 Ross Kirsling 2019-06-26 13:47:34 PDT
(In reply to Fujii Hironori from comment #9)
> (In reply to Fujii Hironori from comment #6)
> > My bad. The test code seems removed already.
> 
> Oh, it still is in Tools/MiniBrowser/win/MiniBrowserWebHost.cpp.
> It is SimpleEventListener. This code became dead. Could you remove this?

Patch submitted @ bug 199233.
Comment 11 Radar WebKit Bug Importer 2019-06-26 16:11:22 PDT
<rdar://problem/52216674>
Comment 12 Radar WebKit Bug Importer 2019-06-26 16:11:23 PDT
<rdar://problem/52216675>