Bug 199187

Summary: When Caps Lock is enabled on the Smart Keyboard, can't scroll with space or arrow keys
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tim Horton
Reported 2019-06-25 01:45:33 PDT
When Caps Lock is enabled on the Smart Keyboard, can't scroll with space or arrow keys
Attachments
Patch (1.72 KB, patch)
2019-06-25 01:45 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-06-25 01:45:38 PDT
Created attachment 372826 [details] Patch
Tim Horton
Comment 2 2019-06-25 01:45:41 PDT
<rdar://problem/51521709>
Anders Carlsson
Comment 3 2019-06-25 06:44:46 PDT
Comment on attachment 372826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372826&action=review > Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm:246 > + auto relevantModifierFlags = WebEventFlagMaskOptionKey | WebEventFlagMaskCommandKey | WebEventFlagMaskShiftKey; Looks like WebEventFlag should be an OptionSet.
Tim Horton
Comment 4 2019-06-25 10:00:02 PDT
Quite!
WebKit Commit Bot
Comment 5 2019-06-25 10:29:59 PDT
Comment on attachment 372826 [details] Patch Clearing flags on attachment: 372826 Committed r246795: <https://trac.webkit.org/changeset/246795>
WebKit Commit Bot
Comment 6 2019-06-25 10:30:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.