Summary: | [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, ews-watchlist, jbedard, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Aakash Jain
2019-06-24 16:55:58 PDT
Created attachment 372810 [details]
Patch
Attachment 372810 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:1104: [ExtractTestResults.__init__] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1491: [TestUploadTestResults.test_success_with_identifier] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1491: [TestUploadTestResults.test_success_with_identifier] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1535: [TestExtractTestResults.test_success_with_identifier] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1535: [TestExtractTestResults.test_success_with_identifier] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
Total errors found: 5 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 372810 [details] Patch Clearing flags on attachment: 372810 Committed r246793: <https://trac.webkit.org/changeset/246793> All reviewed patches have been landed. Closing bug. |