| Summary: | Enable a debug WebRTC mode without any encryption | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, hi, joepeck, rniwa, webkit-bug-importer, youennf | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
youenn fablet
2019-06-24 15:38:34 PDT
This was requested to easily debug, for instance video codec issues. This can be done using PeerConnectionFactoryInterface::Options::disable_encryption Created attachment 373151 [details]
Patch
Comment on attachment 373151 [details] Patch Attachment 373151 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12607036 New failing tests: webrtc/pc-detached-document.html Created attachment 373159 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 373151 [details] Patch Attachment 373151 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12607109 New failing tests: webrtc/pc-detached-document.html Created attachment 373165 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Created attachment 373602 [details]
Patch
Comment on attachment 373602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373602&action=review The inspector parts of this look fine to me. Is there a test for it (inspector-specific or otherwise)? > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:96 > + if (page && page->settings().webRTCEncryptionEnabled()) Should this be `!page->settings().webRTCEncryptionEnabled()`? Created attachment 373642 [details]
Patch for landing
(In reply to Devin Rousso from comment #9) > Comment on attachment 373602 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373602&action=review > > The inspector parts of this look fine to me. Is there a test for it > (inspector-specific or otherwise)? I added a test for the webrtc switch. I did manual testing for the web inspector part. > > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:96 > > + if (page && page->settings().webRTCEncryptionEnabled()) > > Should this be `!page->settings().webRTCEncryptionEnabled()`? Fixed. Has this landed? Comment on attachment 373642 [details] Patch for landing Clearing flags on attachment: 373642 Committed r247438: <https://trac.webkit.org/changeset/247438> All reviewed patches have been landed. Closing bug. |