Summary: | [WPE][GTK] Fixes for compilation with unified builds disabled | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||
Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, koivisto, mcatanzaro, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Adrian Perez
2019-06-24 07:07:05 PDT
Created attachment 372756 [details]
Patch
Comment on attachment 372756 [details]
Patch
It's going to be all for naught without an EWS.
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 372756 [details] > Patch > > It's going to be all for naught without an EWS. I have a crappy script locally which picks the “compile_commands.json” file and runs over the sources using “-fsyntax-only” with Clang and that is able to find out the missing includes/declarations without making the compiler do optimizations/code-generation. I want to make make some measurements once it can run Clang in parallel (right now it's serial) to know how fast such an EWS would be before proposing adding it ;-) Comment on attachment 372756 [details] Patch Clearing flags on attachment: 372756 Committed r246734: <https://trac.webkit.org/changeset/246734> All reviewed patches have been landed. Closing bug. |