Summary: | Add OverflowScrollProxyNodes to the scrolling tree | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | Scrolling | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=199432 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 199133 | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2019-06-22 17:36:08 PDT
Created attachment 372692 [details]
Patch
Attachment 372692 [details] did not pass style-queue:
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:58: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
Total errors found: 1 in 31 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 372692 [details] Patch Clearing flags on attachment: 372692 Committed r246723: <https://trac.webkit.org/changeset/246723> All reviewed patches have been landed. Closing bug. |