Bug 199132

Summary: Add OverflowScrollProxyNodes to the scrolling tree
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199432
Bug Depends on:    
Bug Blocks: 199133    
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2019-06-22 17:36:08 PDT
Add OverflowScrollProxyNodes to the scrolling tree
Attachments
Patch (60.61 KB, patch)
2019-06-22 17:42 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-06-22 17:42:22 PDT
Created attachment 372692 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-06-22 17:43:03 PDT
<rdar://problem/52024717>
EWS Watchlist
Comment 3 2019-06-22 17:43:29 PDT
Attachment 372692 [details] did not pass style-queue: ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:58: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 4 2019-06-23 12:34:51 PDT
Comment on attachment 372692 [details] Patch Clearing flags on attachment: 372692 Committed r246723: <https://trac.webkit.org/changeset/246723>
WebKit Commit Bot
Comment 5 2019-06-23 12:34:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.