Bug 199124

Summary: Layout Test http/tests/appcache/remove-cache.html is a flaky failure
Product: WebKit Reporter: Russell Epstein <repstein>
Component: Tools / TestsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=55160
Attachments:
Description Flags
Patch none

Description Russell Epstein 2019-06-21 17:07:01 PDT 
The following layout test is flaky on WK1 ( though it has failed once on High Sierra WK2).

http/tests/appcache/remove-cache.html

Intermittently, the test is outputting an additional deprecation warning, causing the test to fail (see diff).

Steps to Reproduce:

run-webkit-tests --iter 1000 -f -1 http/tests/appcache/remove-cache.html

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fappcache%2Fremove-cache.html

Diff:

--- /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/http/tests/appcache/remove-cache-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/http/tests/appcache/remove-cache-actual.txt
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
 CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
 CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
 CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
Comment 1 Russell Epstein 2019-06-21 17:08:02 PDT 
This does not appear to be a recent regression.
Comment 2 Radar WebKit Bug Importer 2019-06-21 17:08:18 PDT 
<rdar://problem/52008712>
Comment 3 Ryan Haddad 2019-09-13 11:35:58 PDT 
Still happening, we should mark this as flaky.
Comment 4 Russell Epstein 2019-09-13 11:47:25 PDT 
(In reply to Ryan Haddad from comment #3)
> Still happening, we should mark this as flaky.

Updated TestExpectations in r249844.
Comment 5 youenn fablet 2019-11-05 00:20:44 PST 
The script has a global state so it cannot be run in parallel with itself, hence why run-webkit-tests --iter 1000 -f will fail.
In that case, the flakiness is due to the fact that a timeout kicks in and reload the main page, hence a new console message.
Comment 6 youenn fablet 2019-11-05 00:24:54 PST 
Created attachment 382810 [details]
Patch
Comment 7 youenn fablet 2019-11-07 16:06:54 PST 
Ping review?
Comment 8 WebKit Commit Bot 2019-11-07 16:52:36 PST 
Comment on attachment 382810 [details]
Patch

Clearing flags on attachment: 382810

Committed r252217: <https://trac.webkit.org/changeset/252217>
Comment 9 WebKit Commit Bot 2019-11-07 16:52:38 PST 
All reviewed patches have been landed.  Closing bug.