Bug 199099

Summary: Try to use C++14 std::enable_if_t in CheckedArithmetic.h again
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Web Template FrameworkAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, ross.kirsling, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=195187
Attachments:
Description Flags
Patch ross.kirsling: review+

Fujii Hironori
Reported 2019-06-20 21:06:46 PDT
Try to use C++14 std::enable_if_t in CheckedArithmetic.h again Bug 195187 changed CheckedArithmetic to not use std::enable_if_t. Let's try C++14 again. [webkit-dev] Which WTF headers still should be in C++11? https://lists.webkit.org/pipermail/webkit-dev/2019-June/030692.html
Attachments
Patch (3.58 KB, patch)
2019-06-20 21:10 PDT, Fujii Hironori 		ross.kirsling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-06-20 21:10:06 PDT
Created attachment 372614 [details] Patch
Fujii Hironori
Comment 2 2019-06-20 22:19:52 PDT
Committed r246670: <https://trac.webkit.org/changeset/246670>
Radar WebKit Bug Importer
Comment 3 2019-06-20 22:24:08 PDT
<rdar://problem/51974955>
Yusuke Suzuki
Comment 4 2019-06-21 00:19:21 PDT
I think it is time to use C++17 constexpr-if :)
Note You need to log in before you can comment on or make changes to this bug.