Summary: | Resolve frequent crashes in String::isolatedCopy inside topPrivatelyControlledDomain call | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, beidson, bfulgham, cdumez, commit-queue, ggaren, jfbastien, rniwa, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Safari 10 | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Brent Fulgham
2019-06-20 11:16:15 PDT
Created attachment 372575 [details]
Patch
Comment on attachment 372575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372575&action=review > Source/WebKit/ChangeLog:17 > + (2) Call WebCore::topPrivatelyControlledDomain during NetworkProcess initialization (before We probably do not need 2 given we have 1. Comment on attachment 372575 [details] Patch Rejecting attachment 372575 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 372575, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/12534056 Committed r246652: <https://trac.webkit.org/changeset/246652> Comment on attachment 372575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372575&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:293 > + UNUSED_PARAM(initialized); This is not a parameter, so using the UNUSED_PARAM macro is incorrect. (In reply to Alexey Proskuryakov from comment #6) > Comment on attachment 372575 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372575&action=review > > > Source/WebKit/NetworkProcess/NetworkProcess.cpp:293 > > + UNUSED_PARAM(initialized); > > This is not a parameter, so using the UNUSED_PARAM macro is incorrect. I removed that code. |