Bug 199052

Summary:

Web Inspector: Edit -> Tag doesn't do anything for html, head, and body elements

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Description Nikita Vasilyev 2019-06-19 18:35:17 PDT

Steps:
1. Open https://webkit.org
2. Inspect <body>
3. Right click on <body>
4. Select "Edit -> Tag"

Actual:
Nothing happens.

Expected:
Either start editing "body" or disable (gray out) the "Tag" menu item.

Comment 1 Radar WebKit Bug Importer 2019-06-19 18:40:16 PDT

<rdar://problem/51923906>

Comment 2 Devin Rousso 2019-06-20 10:24:24 PDT

Created attachment 372566 [details]
Patch

Comment 3 Matt Baker 2019-06-20 13:21:28 PDT

Comment on attachment 372566 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372566&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:801
> +            if (!DOMTreeElement.EditTagBlacklist.has(this.representedObject.nodeNameInCorrectCase())) {

Nit: I'd move `let tagNameNode = event.target.closest(".html-tag-name");` (line 746 above) to here to where it is used.

Comment 4 Devin Rousso 2019-06-20 15:12:20 PDT

Created attachment 372591 [details]
Patch

Comment 5 WebKit Commit Bot 2019-06-20 15:45:23 PDT

Comment on attachment 372591 [details]
Patch

Clearing flags on attachment: 372591

Committed r246658: <https://trac.webkit.org/changeset/246658>

Comment 6 WebKit Commit Bot 2019-06-20 15:45:24 PDT

All reviewed patches have been landed.  Closing bug.