Bug 199052

Summary: Web Inspector: Edit -> Tag doesn't do anything for html, head, and body elements
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Nikita Vasilyev
Reported 2019-06-19 18:35:17 PDT
Steps: 1. Open https://webkit.org 2. Inspect <body> 3. Right click on <body> 4. Select "Edit -> Tag" Actual: Nothing happens. Expected: Either start editing "body" or disable (gray out) the "Tag" menu item.
Attachments
Patch (5.35 KB, patch)
2019-06-20 10:24 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (5.33 KB, patch)
2019-06-20 15:12 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-19 18:40:16 PDT
<rdar://problem/51923906>
Devin Rousso
Comment 2 2019-06-20 10:24:24 PDT
Created attachment 372566 [details] Patch
Matt Baker
Comment 3 2019-06-20 13:21:28 PDT
Comment on attachment 372566 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372566&action=review r=me > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:801 > + if (!DOMTreeElement.EditTagBlacklist.has(this.representedObject.nodeNameInCorrectCase())) { Nit: I'd move `let tagNameNode = event.target.closest(".html-tag-name");` (line 746 above) to here to where it is used.
Devin Rousso
Comment 4 2019-06-20 15:12:20 PDT
Created attachment 372591 [details] Patch
WebKit Commit Bot
Comment 5 2019-06-20 15:45:23 PDT
Comment on attachment 372591 [details] Patch Clearing flags on attachment: 372591 Committed r246658: <https://trac.webkit.org/changeset/246658>
WebKit Commit Bot
Comment 6 2019-06-20 15:45:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.