Bug 199031

Summary:

[ews-build] Patch link should open the pretty patch

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2019-06-19 13:46:56 PDT

EWS builds have a link to patch, however it opens the plain text version of the patch which isn't much readable. It would be better to link to prettypatch which is more readable (and shows the diff in color).

Comment 1 Aakash Jain 2019-06-19 13:48:09 PDT

Created attachment 372491 [details]
Patch

Comment 2 Aakash Jain 2019-06-19 13:49:25 PDT

The difference is:

https://bugs.webkit.org/attachment.cgi?id=372491
vs
https://bugs.webkit.org/attachment.cgi?id=372491&action=prettypatch

Comment 3 WebKit Commit Bot 2019-06-19 15:45:58 PDT

Comment on attachment 372491 [details]
Patch

Clearing flags on attachment: 372491

Committed r246613: <https://trac.webkit.org/changeset/246613>

Comment 4 WebKit Commit Bot 2019-06-19 15:45:59 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-06-19 15:48:44 PDT

<rdar://problem/51917356>