Bug 198996

Summary: [GTK] Page blinks after navigation swipe if it triggered PSON
Product: WebKit Reporter: Alexander Mikhaylenko <alexm>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, commit-queue, ews-watchlist, gns, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alexander Mikhaylenko 2019-06-19 05:52:48 PDT
See the patch.
Comment 1 Alexander Mikhaylenko 2019-06-19 05:56:14 PDT
Created attachment 372456 [details]
Patch
Comment 2 EWS Watchlist 2019-06-19 05:57:51 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Michael Catanzaro 2019-06-19 09:12:06 PDT
Comment on attachment 372456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372456&action=review

Good job, thanks!

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1715
> +    WebKitWebViewBasePrivate* priv = webkitWebViewBase->priv;
> +
> +    priv->viewGestureController = nullptr;

Style nit, since it's only used for this one line:

webkitWebViewBase->priv->viewGestureController = nullptr;
Comment 4 Alexander Mikhaylenko 2019-06-19 09:21:56 PDT
Created attachment 372465 [details]
Patch
Comment 5 WebKit Commit Bot 2019-06-19 10:13:31 PDT
Comment on attachment 372465 [details]
Patch

Clearing flags on attachment: 372465

Committed r246592: <https://trac.webkit.org/changeset/246592>
Comment 6 WebKit Commit Bot 2019-06-19 10:13:32 PDT
All reviewed patches have been landed.  Closing bug.