Bug 198996

Summary: [GTK] Page blinks after navigation swipe if it triggered PSON
Product: WebKit Reporter: Alice Mikhaylenko <alicem>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, commit-queue, ews-watchlist, gustavo, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alice Mikhaylenko
Reported 2019-06-19 05:52:48 PDT
See the patch.
Attachments
Patch (5.54 KB, patch)
2019-06-19 05:56 PDT, Alice Mikhaylenko 		no flags
DetailsFormatted DiffDiff
Patch (5.50 KB, patch)
2019-06-19 09:21 PDT, Alice Mikhaylenko 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alice Mikhaylenko
Comment 1 2019-06-19 05:56:14 PDT
Created attachment 372456 [details] Patch
EWS Watchlist
Comment 2 2019-06-19 05:57:51 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 3 2019-06-19 09:12:06 PDT
Comment on attachment 372456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372456&action=review Good job, thanks! > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1715 > + WebKitWebViewBasePrivate* priv = webkitWebViewBase->priv; > + > + priv->viewGestureController = nullptr; Style nit, since it's only used for this one line: webkitWebViewBase->priv->viewGestureController = nullptr;
Alice Mikhaylenko
Comment 4 2019-06-19 09:21:56 PDT
Created attachment 372465 [details] Patch
WebKit Commit Bot
Comment 5 2019-06-19 10:13:31 PDT
Comment on attachment 372465 [details] Patch Clearing flags on attachment: 372465 Committed r246592: <https://trac.webkit.org/changeset/246592>
WebKit Commit Bot
Comment 6 2019-06-19 10:13:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.