Bug 198982

Summary: Hook up WebGL's back buffer in ANGLE backend on macOS
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 197755    
Bug Blocks: 198948    
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2019-06-18 16:41:44 PDT
In bug 197755 a preliminary ANGLE backend was added to WebCore's WebGL implementation which doesn't render anything yet. The back buffer needs to be hooked up on the macOS port as a start.
Attachments
Patch (105.91 KB, patch)
2019-07-09 20:56 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2019-07-09 20:56:26 PDT
Created attachment 373816 [details] Patch
EWS Watchlist
Comment 2 2019-07-09 20:58:47 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 3 2019-07-09 20:59:09 PDT
The attached patch fixes many bugs encountered along the way toward getting the ANGLE backend for WebKit's WebGL implementation to draw correctly to the screen on desktop macOS. It runs the San Angeles demo correctly, as well as parts of the WebGL 1.0 conformance suite. If necessary the patch can be split up, though this will be a bit difficult since the intermediate patches can't be tested until all of them land.
WebKit Commit Bot
Comment 4 2019-07-10 11:43:08 PDT
Comment on attachment 373816 [details] Patch Clearing flags on attachment: 373816 Committed r247315: <https://trac.webkit.org/changeset/247315>
WebKit Commit Bot
Comment 5 2019-07-10 11:43:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-07-10 11:44:15 PDT
<rdar://problem/52903988>
Note You need to log in before you can comment on or make changes to this bug.