Summary: | Non-standard Error properties should not be enumerable | ||
---|---|---|---|
Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> |
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Minor | CC: | commit-queue, ews-watchlist, guijemont, guijemont+jsc-armv7-ews, keith_miller, mark.lam, msaboff, rniwa, ross.kirsling, saam, tzagallo, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=86128 | ||
Attachments: |
Description
Alexey Shvayka
2019-06-18 13:35:38 PDT
Created attachment 372375 [details]
Patch
Comment on attachment 372375 [details]
Patch
r=me
Comment on attachment 372375 [details] Patch Attachment 372375 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12512194 New failing tests: inspector/debugger/setPauseOnExceptions-none.html inspector/debugger/setPauseOnExceptions-uncaught.html inspector/debugger/setPauseOnExceptions-all.html js/exception-properties.html Created attachment 372384 [details]
Archive of layout-test-results from ews103 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 372375 [details] Patch Attachment 372375 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12512267 New failing tests: inspector/debugger/setPauseOnExceptions-none.html inspector/debugger/setPauseOnExceptions-uncaught.html inspector/debugger/setPauseOnExceptions-all.html js/exception-properties.html Created attachment 372385 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 372375 [details] Patch Attachment 372375 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12512523 New failing tests: inspector/debugger/setPauseOnExceptions-none.html inspector/debugger/setPauseOnExceptions-uncaught.html inspector/debugger/setPauseOnExceptions-all.html js/exception-properties.html Created attachment 372392 [details]
Archive of layout-test-results from ews117 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 372375 [details] Patch Attachment 372375 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12512595 New failing tests: js/exception-properties.html Created attachment 372395 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Comment on attachment 372375 [details]
Patch
Looks like this broke some tests. r- until the issue is resolved.
Created attachment 372410 [details]
Patch
Adjust tests.
Comment on attachment 372410 [details] Patch Attachment 372410 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12514862 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-llint microbenchmarks/let-for-in.js.default microbenchmarks/let-for-in.js.ftl-eager-no-cjit-b3o1 microbenchmarks/let-for-in.js.dfg-maximal-flush-validate-no-cjit microbenchmarks/let-for-in.js.ftl-no-cjit-small-pool microbenchmarks/let-for-in.js.ftl-no-cjit-validate-sampling-profiler microbenchmarks/let-for-in.js.no-llint microbenchmarks/let-for-in.js.no-ftl microbenchmarks/let-for-in.js.ftl-eager microbenchmarks/let-for-in.js.dfg-eager-no-cjit-validate microbenchmarks/let-for-in.js.no-cjit-validate-phases microbenchmarks/let-for-in.js.dfg-eager microbenchmarks/let-for-in.js.ftl-no-cjit-b3o0 microbenchmarks/let-for-in.js.ftl-eager-no-cjit microbenchmarks/let-for-in.js.ftl-no-cjit-no-inline-validate ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js.default microbenchmarks/let-for-in.js.no-cjit-collect-continuously microbenchmarks/let-for-in.js.bytecode-cache microbenchmarks/let-for-in.js.ftl-no-cjit-no-put-stack-validate microbenchmarks/let-for-in.js.mini-mode mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-ftl-eager-no-cjit-validate-phases apiTests Comment on attachment 372410 [details] Patch Attachment 372410 [details] did not pass jsc-armv7-ews (jsc-only): Output: https://webkit-queues.webkit.org/results/12516558 New failing tests: microbenchmarks/let-for-in.js.dfg-maximal-flush-validate-no-cjit microbenchmarks/let-for-in.js.default microbenchmarks/let-for-in.js.no-cjit-validate-phases microbenchmarks/let-for-in.js.no-llint microbenchmarks/let-for-in.js.dfg-eager-no-cjit-validate ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js.default microbenchmarks/let-for-in.js.no-cjit-collect-continuously microbenchmarks/let-for-in.js.dfg-eager microbenchmarks/let-for-in.js.mini-mode apiTests Created attachment 372451 [details]
Patch
Fix some more tests.
Created attachment 379739 [details]
Patch
Rebase patch and revert modification of ChakraCore test.
Comment on attachment 379739 [details] Patch Clearing flags on attachment: 379739 Committed r250436: <https://trac.webkit.org/changeset/250436> All reviewed patches have been landed. Closing bug. |