Bug 198973

Summary: WebSocketDeflater uses an unnecessarily constrained compression memory level
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, commit-queue, joepeck, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202401
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2019-06-18 12:07:56 PDT
WebSocketDeflater uses an unnecessarily constrained compression memory level The default value for compression mem level is 8. WebSocketDeflater is using 1, which may be slow: > The memLevel parameter specifies how much memory should be allocated for the internal > compression state. memLevel=1 uses minimum memory but is slow and reduces compression > ratio; memLevel=9 uses maximum memory for optimal speed. The default value is 8. See > zconf.h for total memory usage as a function of windowBits and memLevel. A quick shows other browsers also appear to use the true default (8): - blink: https://chromiumcodereview.appspot.com/23623008 - net/websockets/websocket_deflater.cc - mozilla: https://hg.mozilla.org/mozilla-central/rev/724f0a71d621 - netwerk/protocol/websocket/WebSocketChannel.cpp
Attachments
[PATCH] Proposed Fix (1.23 KB, patch)
2019-06-18 12:10 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2019-06-18 12:10:06 PDT
Created attachment 372360 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2019-06-18 15:30:00 PDT
Comment on attachment 372360 [details] [PATCH] Proposed Fix Clearing flags on attachment: 372360 Committed r246573: <https://trac.webkit.org/changeset/246573>
WebKit Commit Bot
Comment 3 2019-06-18 15:30:02 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-06-18 15:36:37 PDT
<rdar://problem/51869119>
Note You need to log in before you can comment on or make changes to this bug.