Bug 198971

Summary: Web Inspector: parseQueryParameters fails to successfully parse query parameter values that contain "="
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2019-06-18 11:32:09 PDT
As an example, "a=b=c" should be parsed as `{a: "b=c"}`, but it currently is parsed as `{a: "b"}`.
Attachments
Patch (5.53 KB, patch)
2019-06-18 11:33 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (5.67 KB, patch)
2019-06-18 11:44 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-06-18 11:32:27 PDT
<rdar://problem/51852782>
Devin Rousso
Comment 2 2019-06-18 11:33:43 PDT
Created attachment 372354 [details] Patch
Joseph Pecoraro
Comment 3 2019-06-18 11:39:32 PDT
Comment on attachment 372354 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372354&action=review > LayoutTests/inspector/unit-tests/url-utilities.html:413 > + test("a&b=1&c==2=&d&e=3&f==4=", {a: "", b: "1", c: "=2=", d: "", e: "3", f: "=4="}); Would be nice to have one that has encoded values / keys, etc. test("a=foo%20bar&b=123%3A456, {a: "foo bar", b: "123:456"})
Devin Rousso
Comment 4 2019-06-18 11:44:42 PDT
Created attachment 372356 [details] Patch
WebKit Commit Bot
Comment 5 2019-06-18 12:37:42 PDT
Comment on attachment 372356 [details] Patch Clearing flags on attachment: 372356 Committed r246559: <https://trac.webkit.org/changeset/246559>
WebKit Commit Bot
Comment 6 2019-06-18 12:37:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.