Summary: | [iOS] Pressing key while holding Command should not insert character | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, webkit-bug-importer, wenson_hsieh | ||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||
Version: | WebKit Local Build | ||||||
Hardware: | iPhone / iPad | ||||||
OS: | iOS 12 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 190571 | ||||||
Attachments: |
|
Description
Daniel Bates
2019-06-17 11:13:39 PDT
Created attachment 372259 [details]
Patch and test
If I have a moment, I will look to write a more comprehensive test. Maybe I could modify the fast/events/ios/key-event-comprehensive tests. I didn't want to now since these tests already run longish and I did not want to tempt fate with a modification that could make them run even longer ... and timeout. Maybe I could duplicate these tests as an alternative.
Comment on attachment 372259 [details] Patch and test View in context: https://bugs.webkit.org/attachment.cgi?id=372259&action=review Looks reasonable. r=me. > Source/WebKit/ChangeLog:11 > + time of writing) should not insert v. This matches iOS and Mac platform conventions. Yes! Comment on attachment 372259 [details] Patch and test Clearing flags on attachment: 372259 Committed r246564: <https://trac.webkit.org/changeset/246564> All reviewed patches have been landed. Closing bug. |