Bug 198924

Summary: http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html is a Flakey Failure
Product: WebKit Reporter: Russell Epstein <repstein>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, dbates, ews-watchlist, mkwst, repstein, ryanhaddad, sroberts, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Russell Epstein 2019-06-17 10:29:37 PDT
http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html has been flakily failing in WK1.

Frequency of failure appears to have increased recently.

Point of regression is not obvious because older builds are still failing.

Steps to Reproduce:

run-webkit-tests --iter 10000 --exit-after-n-failures 1 -f -1 http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html 

History:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2FisolatedWorld%2Fbypass-main-world-csp-worker.html

Diff:

--- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/http/tests/security/isolatedWorld/bypass-main-world-csp-worker-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/http/tests/security/isolatedWorld/bypass-main-world-csp-worker-actual.txt
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 3: ReferenceError: Can't find variable: alert
 This tests that in an isolated world the Content Security Policy of the parent origin (this page) is bypassed and a Web Worker is allowed to be instantiated with a script URL not listed in the CSP of the page.
 
 PASS worker instantiated.
Comment 1 Radar WebKit Bug Importer 2019-06-17 10:31:45 PDT
<rdar://problem/51811010>
Comment 2 Daniel Bates 2019-10-31 12:54:06 PDT
Created attachment 382487 [details]
Patch
Comment 3 Daniel Bates 2019-10-31 12:55:56 PDT
Created attachment 382488 [details]
Patch
Comment 4 Brent Fulgham 2019-11-06 09:12:20 PST
Comment on attachment 382488 [details]
Patch

Looks reasonable. r=me!
Comment 5 Daniel Bates 2019-11-06 09:36:39 PST
Comment on attachment 382488 [details]
Patch

Clearing flags on attachment: 382488

Committed r252139: <https://trac.webkit.org/changeset/252139>
Comment 6 Daniel Bates 2019-11-06 09:36:41 PST
All reviewed patches have been landed.  Closing bug.