| Summary: | Experiment with simple structured bindings use | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
| Component: | WebCore Misc. | Assignee: | Sam Weinig <sam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 198914 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Sam Weinig
2019-06-16 13:05:13 PDT
Created attachment 372227 [details]
Patch
Attachment 372227 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/URLHelpers.cpp:732: Extra space before [. [whitespace/brackets] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Build Bot from comment #2) > Attachment 372227 [details] did not pass style-queue: > > > ERROR: Source/WTF/wtf/URLHelpers.cpp:732: Extra space before [. > [whitespace/brackets] [5] > Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Filed https://bugs.webkit.org/show_bug.cgi?id=198906 for this. Comment on attachment 372227 [details]
Patch
Looks like this is going to work once we upgrade those last two EWS bots.
Created attachment 372882 [details]
Try again
Attachment 372882 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/URLHelpers.cpp:732: Extra space before [. [whitespace/brackets] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 372882 [details] Try again Clearing flags on attachment: 372882 Committed r246826: <https://trac.webkit.org/changeset/246826> All reviewed patches have been landed. Closing bug. |