Bug 198898

Summary:

Streamline some string code, focusing on functions that were using substringSharingImpl

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebCore Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, ews-watchlist, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews117 for mac-highsierra	none
Patch	dbates: review+

Darin Adler

Reported 2019-06-15 19:24:20 PDT

Streamline some string code, focusing on functions that were using substringSharingImpl

Attachments
Patch (31.68 KB, patch) 2019-06-16 08:58 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews117 for mac-highsierra (3.26 MB, application/zip) 2019-06-16 11:05 PDT, EWS Watchlist	no flags	Details
Patch (33.37 KB, patch) 2019-06-22 15:11 PDT, Darin Adler	dbates: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2019-06-16 08:58:32 PDT Comment hidden (obsolete)

Created attachment 372222 [details] Patch

EWS Watchlist

Comment 2 2019-06-16 11:05:05 PDT Comment hidden (obsolete)

Comment on attachment 372222 [details] Patch Attachment 372222 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12491539 New failing tests: fast/forms/placeholder-pseudo-element-with-webkit-prefix.html fast/css/css-selector-text.html fast/css/css-set-selector-text.html

EWS Watchlist

Comment 3 2019-06-16 11:05:07 PDT Comment hidden (obsolete)

Created attachment 372224 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6

Darin Adler

Comment 4 2019-06-22 15:11:28 PDT

Created attachment 372688 [details] Patch

Daniel Bates

Comment 5 2019-06-22 20:29:04 PDT

Comment on attachment 372688 [details] Patch Nice!

Darin Adler

Comment 6 2019-06-24 11:23:24 PDT

I need to fix whatever problems are causing the GTK and Windows EWS failures. At the moment, the computer I work on isn’t available so there will be a bit of delay.

Darin Adler

Comment 7 2019-06-29 14:50:06 PDT

Committed r246951: <https://trac.webkit.org/changeset/246951>

Radar WebKit Bug Importer

Comment 8 2019-06-29 14:51:19 PDT

<rdar://problem/52394242>

Note You need to log in before you can comment on or make changes to this bug.