Bug 198886

Summary: [LFC][BFC] Fix available width for float avoiders.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2019-06-15 01:12:01 PDT 
it's not always the width of the content box.
Comment 1 Radar WebKit Bug Importer 2019-06-15 01:12:23 PDT 
<rdar://problem/51773643>
Comment 2 zalan 2019-06-15 01:53:50 PDT 
Created attachment 372188 [details]
Patch
Comment 3 EWS Watchlist 2019-06-15 01:56:20 PDT 
Attachment 372188 [details] did not pass style-queue:


ERROR: Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:233:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 zalan 2019-06-15 05:54:09 PDT 
Created attachment 372190 [details]
Patch
Comment 5 Antti Koivisto 2019-06-15 06:37:31 PDT 
Comment on attachment 372190 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372190&action=review

> Source/WebCore/layout/FormattingContext.cpp:179
> +// FIXME turn these into templates.

FIXME:
Comment 6 zalan 2019-06-15 11:47:25 PDT 
Created attachment 372196 [details]
Patch
Comment 7 WebKit Commit Bot 2019-06-15 12:30:12 PDT 
Comment on attachment 372196 [details]
Patch

Clearing flags on attachment: 372196

Committed r246468: <https://trac.webkit.org/changeset/246468>
Comment 8 WebKit Commit Bot 2019-06-15 12:30:14 PDT 
All reviewed patches have been landed.  Closing bug.