Bug 198838
| Summary: | [WHLSL] Ensure MakeArrayReferenceExpression works | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> |
| Component: | WebGPU | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Saam Barati
There's some iffy looking code in metal codegen. E.g:
if (is<AST::PointerType>(makeArrayReferenceExpression.resolvedType()))
m_stringBuilder.append(makeString(mangledTypeName, ' ', variableName, " = { ", lValue, ", 1 };\n"));
I think it should instead be something like " = lvalue"
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Saam Barati
I'm gonna fly by change it in a patch I'm writing for OOB accesses, but it needs to be tested and thought through in a more thorough way.
Saam Barati
(In reply to Saam Barati from comment #1)
> I'm gonna fly by change it in a patch I'm writing for OOB accesses, but it
> needs to be tested and thought through in a more thorough way.
I'm not doing this. The bug is the code is checking the result type. It should be checking the base type.
Myles C. Maxfield
WHLSL is no longer relevant.