| Summary: | [GTK] Several media related tests crash sometimes with the same error | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Miguel Gomez <magomez> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW --- | ||
| Severity: | Normal | CC: | bugs-noreply, calvaris, cturner, dpino, lmoura, pnormand, tpopela, vjaquez |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugzilla.redhat.com/show_bug.cgi?id=1732799 https://bugs.webkit.org/show_bug.cgi?id=210635 |
||
|
Description
Miguel Gomez
2019-06-13 07:22:08 PDT
And more crashing somtimes with the same trace imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_loadedmetadata_noautoplay.html [ Crash ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_playing_noautoplay.html [ Crash ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_playing.html [ Crash ] media/audio-controls-rendering.html [ Crash ] media/media-fullscreen-inline.html [ Crash ] media/nodesFromRect-shadowContent.html [ Crash ] media/progress-events-generated-correctly.html [ Crash ] media/track/track-mode-disabled-crash.html [ Crash ] media/W3C/video/events/event_canplay.html [ Crash ] media/W3C/video/paused/paused_false_during_play.html [ Crash ] media/W3C/video/readyState/readyState_during_playing.html [ Crash ] More tests crashing with the same bt: http/tests/media/media-document-referer.html [ Crash ] media/accessibility-closed-captions-has-aria-owns.html [ Crash ] media/W3C/video/events/event_canplay_manual.html [ Crash ] media/W3C/video/events/event_canplaythrough.html [ Crash ] media/W3C/video/events/event_playing_manual.html [ Crash ] media/W3C/video/readyState/readyState_during_loadeddata.html [ Crash ] media/W3C/video/readyState/readyState_during_loadedmetadata.html [ Crash ] media/track/track-active-cues.html [ Crash ] media/track/track-css-all-cues.html [ Crash ] More tests crashing because of this. Some of them also timeout sometimes: media/media-fragments/TC0003.html [ Pass Crash ] media/media-fragments/TC0033.html [ Pass Crash ] media/media-fragments/TC0055.html [ Pass Timeout Crash ] media/media-fragments/TC0035.html [ Pass Timeout Crash ] media/media-fragments/TC0039.html [ Pass Timeout Crash ] media/media-fragments/TC0052.html [ Pass Timeout Crash ] media/media-fragments/TC0053.html [ Pass Timeout Crash ] media/media-fragments/TC0054.html [ Pass Timeout Crash ] media/media-fragments/TC0059.html [ Pass Timeout Crash ] And more: media/W3C/video/readyState/readyState_during_canplay.html [ Pass Crash ] media/W3C/video/readyState/readyState_during_canplaythrough.html [ Pass Crash ] media/audio-only-video-intrinsic-size.html [ Pass Crash ] media/media-controls-timeline-updates-after-playing.html [ Pass Timeout Crash ] media/media-controls-timeline-updates-when-hovered.html [ Pass Crash ] media/track/track-cue-left-align.html [ Pass Crash ] media/audio-controls-timeline-in-media-document.html [ Failure Pass Crash ] media/auto-play-in-sandbox-with-allow-scripts.html [ Pass Timeout Crash ] media/track/track-cues-pause-on-exit.html [ Pass Timeout Crash ] media/track/video/video-track-mkv-theora-selected.html [ Failure Timeout Pass Crash ] media/media-source/media-source-paint-to-canvas.html [ Failure Timeout ] And more: media/W3C/video/events/event_loadedmetadata_manual.html [ Crash Pass ] media/W3C/video/networkState/networkState_during_progress.html [ Crash Pass ] media/media-controls-drag-timeline-set-controls-property.html [ Crash Pass ] media/media-fragments/TC0070.html [ Crash Pass ] media/media-fragments/TC0088.html [ Crash Pass ] media/track/track-mode-not-changed-by-new-track.html [ Crash Pass ] media/video-buffering-allowed.html [ Crash Pass ] media/video-dom-autoplay.html [ Crash Pass ] userscripts/user-script-audio-document.html [ Crash Pass ] Was any investigation done to fix this X11 crash? (In reply to Philippe Normand from comment #6) > Was any investigation done to fix this X11 crash? Not that I know of. More tests: * media/W3C/video/events/event_order_canplay_playing.html [ Crash ] * media/audio-as-video-fullscreen.html [ Crash ] * media/audio-repaint.html [ Crash ] * media/controls-styling-strict.html [ Crash ] * media/media-controller-timeupdate.html [ Crash ] * media/media-controls-invalid-url.html [ Crash ] * media/media-controls-play-button-updates.html [ Crash ] * media/media-fragments/TC0031.html [ Crash ] * media/media-fragments/TC0072.html [ Crash ] * media/media-fragments/TC0081.html [ Crash ] * media/media-fragments/TC0094.html [ Crash ] * media/track/track-cue-rendering-on-resize.html [ Crash ] * media/track/track-cue-rendering-tree-is-removed-properly.html [ Crash ] * media/track/track-cues-sorted-before-dispatch.html [ Crash ] * media/track/track-disabled.html [ Crash ] * media/track/track-in-band-cues-added-once.html [ Crash ] * media/track/track-insert-after-load-crash.html [ Crash ] * media/track/track-remove-active-cue-crash.html [ Crash ] * media/track/video-track.html [ Crash ] * media/video-autoplay-allowed-but-fullscreen-required.html [ Crash ] * media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html [ Crash ] * media/video-controls-drop-and-restore-timeline.html [ Crash ] * media/video-controls-fullscreen-volume.html [ Crash ] * media/video-controls-visible-audio-only.html [ Crash ] * media/video-does-not-loop.html [ Crash ] * media/video-element-other-namespace-crash.html [ Crash ] * media/video-fullscreen-only-controls.html [ Crash ] * media/video-fullscreen-only-playback.html [ Crash ] * media/video-fullscreen-reload-crash.html [ Crash ] * media/video-muted-holds-sleep-assertion.html [ Crash ] * media/video-pause-play-resolve.html [ Crash ] * media/video-play-empty-events.html [ Crash ] * media/video-playback-restriction-play-before-load.html [ Crash ] * media/video-seek-double.html [ Crash ] * media/video-seek-past-end-playing.html [ Crash ] * media/video-seekable.html [ Crash ] * media/video-source-type.html [ Crash ] * media/video-system-sleep.html [ Crash ] * media/video-timeupdate-during-playback.html [ Crash ] * media/video-volume-slider-drag.html [ Crash ] * media/video-volume.html [ Crash ] About one week before this bug was reported, the xcb package was upgraded in the test bot: > slave@bb-webkit-release-test-64 /var/log $ zgrep xcb1-dev dpkg.log.3.gz > 2019-06-04 01:08:53 upgrade libxcb1-dev:amd64 1.12-1 1.13.1-2 There is also this bug reported in upstream xcb about Skype (Chromium-based) freezing when playing video : * [Regression 1.12->1.13] "read from connection when polling" causes video to freeze https://gitlab.freedesktop.org/xorg/lib/libxcb/issues/19 I tried reverting the referenced commit to see if it changed something but the last set of tests reported by Diego kept crashing. There is also some other bugs that may be related: * Gstreamer: [glimagesink: Xlib / xcb assertion with client-draw signal] https://bugzilla.gnome.org/show_bug.cgi?id=754198 * Closed and opened the mesa bug below as it was assumed it is a driver issue * Mesa: [crash OpenGL rendering to multiple X11 Window in multiple threads] https://gitlab.freedesktop.org/mesa/mesa/issues/754 * No new action other than the initial report * Ubuntu GTK2 app: [!xcb_xlib_threads_sequence_lost error with GTK2 applications] https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1808710 Another bunch of tests with similar behavior: * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_loadeddata_noautoplay.html * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_loadedmetadata.html * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_pause_noautoplay.html * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/networkState_during_progress.html * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/paused_false_during_play.html * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadedmetadata.html * media/media-controller-time.html * media/presentationmodechanged-fired-once.html * media/restore-from-page-cache.html * media/track/track-in-band-duplicate-tracks-when-source-changes.html * media/track/track-in-band-legacy-api.html * media/track/track-kind.html * media/track/video/video-track-mkv-theora-addtrack.html * media/track/video/video-track-mkv-theora-language.html * media/video-controls-audiotracks-trackmenu.html * media/video-controls-captions-trackmenu.html * media/video-controls-in-media-document.html * media/video-controls-no-display-with-text-track.html * media/video-muted.html * media/video-playing-and-pause.html from: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r256478%20(12645)/results.html Was a Mesa upgrade ever considered? I see that Mesa 19.0.4 fixed https://bugs.freedesktop.org/show_bug.cgi?id=99781 which looks exactly like the assert we're hitting... (In reply to Philippe Normand from comment #11) > Was a Mesa upgrade ever considered? I see that Mesa 19.0.4 fixed > https://bugs.freedesktop.org/show_bug.cgi?id=99781 which looks exactly like > the assert we're hitting... Looks like this patch was reverted. Oh well. I think a Mesa upgrade would still be worth a try. Few more crashes from build 12649: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r256503%20(12649)/results.html * http/tests/media/autoplay-if-audio-is-playing.html * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_canplay.html * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_loadeddata.html * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_loadstart.html * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_order_canplay_playing.html * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_progress_noautoplay.html * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/networkState_during_loadstart.html * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html * media/controls-styling.html * media/media-controller-time-clamp.html * media/media-controls-timeline-updates.html * media/media-document-audio-controls-visible.html * media/media-document-audio-repaint.html * media/media-fragments/TC0004.html * media/media-fragments/TC0005.html * media/media-fragments/TC0006.html * media/media-fragments/TC0030.html * media/media-fragments/TC0032.html * media/media-fragments/TC0076.html * media/media-fragments/TC0093.html * media/track/audio/audio-track-mkv-vorbis-addtrack.html * media/track/track-css-matching-lang.html * media/track/track-css-user-override.html * media/track/track-in-band-style.html * media/track/track-mode-disabled-crash.html * media/video-concurrent-playback.html * media/video-controls-captions-trackmenu-includes-enabled-track.html * media/video-ended-seek-crash.html * media/video-inactive-playback.html * media/video-load-preload-metadata-naturalsize.html * media/video-restricted-no-preload-auto.html * media/W3C/audio/events/event_canplay_manual.html * media/W3C/audio/events/event_canplaythrough.html * media/W3C/video/events/event_loadeddata_manual.html * media/W3C/video/events/event_loadeddata.html * media/W3C/video/events/event_loadedmetadata.html * media/W3C/video/events/event_loadstart.html * media/W3C/video/events/event_order_loadstart_progress.html * media/W3C/video/events/event_timeupdate.html Marking more tests as flaky failures: * http/tests/security/contentSecurityPolicy/media-src-allowed.html [ Crash ] * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_playing.html [ Crash ] * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_canplay.html [ Crash ] * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_canplaythrough.html [ Crash ] * imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-after-controls-removed.html [ Crash ] * media/media-controller-time-constant.html [ Crash ] * media/media-fragments/TC0002.html [ Crash ] * media/media-fragments/TC0051.html [ Crash ] * media/media-fragments/TC0068.html [ Crash ] * media/media-fragments/TC0086.html [ Crash ] * media/media-fragments/TC0087.html [ Crash ] * media/remote-control-command-is-user-gesture.html [ Crash ] * media/remote-control-command-seek.html [ Crash ] * media/sources-fallback-codecs.html [ Crash ] * media/track/track-cue-rendering-mode-changed.html [ Crash ] * media/track/track-cues-seeking.html [ Crash ] * media/track/track-delete-during-setup.html [ Crash ] * media/track/track-long-word-container-sizing.html [ Crash ] * media/track/track-remove-by-setting-innerHTML.html [ Crash ] * media/track/track-remove-crash.html [ Crash ] * media/video-append-source.html [ Crash ] * media/video-currentTime-set2.html [ Crash ] * media/video-no-autoplay.html [ Crash ] * media/video-reverse-play-duration.html [ Crash ] * media/video-unmuted-after-play-holds-sleep-assertion.html [ Crash ] * userscripts/user-script-video-document.html [ Crash ] media/track/track-cue-container-rendering-position.html which is returning Crash occasionally and is an entry in TestExpectations, should be tracked under this bug. Added a couple more to the mix: * compositing/overflow/overflow-compositing-descendant.html * http/tests/media/user-gesture-preserved-across-xmlhttprequest.html Some more crashes: * media/video-plays-past-end-of-test.html * media/audio-play-with-video-element.html Looking at this stack trace reported almost a year ago, I'd just recommend to skip all media tests relying on <video> until someone upgrades Mesa (or gets the bots migrated to Flatpak, which has a more recent release), otherwise comments will just keep piling up here :( I was surprised to find this during working on web view tests that also have issues https://bugs.webkit.org/show_bug.cgi?id=210635 (In reply to Philippe Normand from comment #11) > Was a Mesa upgrade ever considered? I see that Mesa 19.0.4 fixed > https://bugs.freedesktop.org/show_bug.cgi?id=99781 which looks exactly like > the assert we're hitting... I'm running on Debian Buster with 18.3.6, and I can't reproduce a crash in media/media-fragments at least, however this is obviously a threading issue, probably more easily reproducible on a machine like the bot with lots of hardware concurrency than my laptop. Maybe Debian has patched Mesa, maybe not. I also run with a master GStreamer, maybe an upgrade there helps (don't know what is on the bot) Skipping all the media tests is not a solution, it's going to make our media backend even less stable than it already is. Is it possible someone with access to the bot can try these upgrades? (In reply to Charlie Turner from comment #19) > I'm running on Debian Buster with 18.3.6, and I can't reproduce a crash in > media/media-fragments at least, however this is obviously a threading issue, > probably more easily reproducible on a machine like the bot with lots of > hardware concurrency than my laptop. > > Maybe Debian has patched Mesa, maybe not. I also run with a master > GStreamer, maybe an upgrade there helps (don't know what is on the bot) > > Skipping all the media tests is not a solution, it's going to make our media > backend even less stable than it already is. Is it possible someone with > access to the bot can try these upgrades? I have Debian testing with 19.3.3-1, but I am running it from JHBuild, so whatever version there is there, GStreamer included. I can reproduce the bug so I guess if this is fixed, it would be in GStreamer. Most of these are no longer flaky, expectations updated in r269029. Another update in r269180 After my checks I would change: media/event-attributes.html [ Failure ] media/media-document-audio-size.html [ Pass ] media/track/track-cue-css.html [ Pass ImageOnlyFailure ] media/progress-events-generated-correctly.html [ Failure ] media/video-dom-autoplay.html [ Pass ] userscripts/user-script-audio-document.html [ Pass ] media/video-fullscreen-reload-crash.html [ Pass ] media/track/audio/audio-track-mkv-vorbis-addtrack.html [ Pass ] media/video-playing-and-pause.html [ Pass ] http/tests/media/autoplay-if-audio-is-playing.html [ Pass ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_playing.html [ Pass ] media/event-attributes.html fixed in r279499 |