| Summary: | [WebGL] ANGLE Extension directive location incorrectly enforced for webgl 1.0 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Fan <justin_fan> |
| Component: | New Bugs | Assignee: | Justin Fan <justin_fan> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | commit-queue, dino, ews-watchlist, graouts, kondapallykalyan, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Attachments: | |||
|
Description
Justin Fan
2019-06-12 15:32:43 PDT
Created attachment 371993 [details]
Patch
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 371993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371993&action=review > LayoutTests/webgl/webgl-extension-directive-location-no-error.html:2 > +<p>Ensure that if a shader extension directive is specified after non-preprocessor symbols, compilation succeeds.</p> I think you should mention that if it fails, output will be in the console log. (In reply to Dean Jackson from comment #4) > Comment on attachment 371993 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371993&action=review > > > LayoutTests/webgl/webgl-extension-directive-location-no-error.html:2 > > +<p>Ensure that if a shader extension directive is specified after non-preprocessor symbols, compilation succeeds.</p> > > I think you should mention that if it fails, output will be in the console > log. Done. Thanks! Created attachment 371995 [details]
Patch
Comment on attachment 371995 [details] Patch Attachment 371995 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12459103 New failing tests: webgl/webgl-extension-directive-location-no-error.html Created attachment 372000 [details]
Archive of layout-test-results from ews103 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 371995 [details] Patch Attachment 371995 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12459115 New failing tests: webgl/webgl-extension-directive-location-no-error.html Created attachment 372001 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 371995 [details] Patch Attachment 371995 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12459004 New failing tests: webgl/webgl-extension-directive-location-no-error.html Created attachment 372005 [details]
Archive of layout-test-results from ews117 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 371995 [details] Patch Attachment 371995 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12459049 New failing tests: webgl/webgl-extension-directive-location-no-error.html Created attachment 372008 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Created attachment 372012 [details]
Patch for landing
Comment on attachment 372012 [details] Patch for landing Rejecting attachment 372012 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 372012, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/12460531 Created attachment 372018 [details]
Patch for landing
Comment on attachment 372018 [details] Patch for landing Clearing flags on attachment: 372018 Committed r246393: <https://trac.webkit.org/changeset/246393> All reviewed patches have been landed. Closing bug. |