Summary: | API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shawn Roberts <sroberts> | ||||
Component: | WebKit API | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aestes, beidson, cdumez, commit-queue, jbedard, keith_miller, ryanhaddad, saam, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Shawn Roberts
2019-06-12 11:05:33 PDT
Adding Wenson who created the test. Andy who made a recent change that affected Catalina, and Saam and Keith who appear to have made some changes in the past on bmalloc::SmallLine::deref and have had recent changes in this area after the test seems to have gotten more flaky? (In reply to Shawn Roberts from comment #1) > Adding Wenson who created the test. Andy who made a recent change that > affected Catalina, and Saam and Keith who appear to have made some changes > in the past on bmalloc::SmallLine::deref and have had recent changes in this > area after the test seems to have gotten more flaky? I don’t think this test failure is relevant to JSC. Disabled test in https://trac.webkit.org/r246739 Created attachment 389890 [details]
Patch
Not against re-enabling this test, but what makes us think it's not flakey? (In reply to Jonathan Bedard from comment #6) > Not against re-enabling this test, but what makes us think it's not flakey? Ah, I'd only put it in the radar: >I cannot reproduce with today’s trunk with the referenced command: >run-api-tests TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments --iter 200 --debug >… or under guardmalloc. > >Seems like this righted itself at some point. Comment on attachment 389890 [details]
Patch
Let's get this landed then, cq+.
The commit-queue encountered the following flaky tests while processing attachment 389890 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 389890 [details] Patch Clearing flags on attachment: 389890 Committed r257817: <https://trac.webkit.org/changeset/257817> All reviewed patches have been landed. Closing bug. |