LayoutTests/fast/events/touch/ios/double-tap-for-double-click* test cases are failing

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

<rdar://problem/51035459>

[zalan]

Created attachment 371871 [details]
Patch

[Wenson Hsieh]

Comment on attachment 371871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371871&action=review

r=mews

> Source/WebKit/Shared/WebPageCreationParameters.cpp:295
> +    if (!decoder.decode(parameters.doubleClickForDoubleTapDelay))

Nit - doubleTapForDoubleClick* sounds a bit more appropriate.

> Source/WebKit/Shared/WebPageCreationParameters.h:161
> +    double doubleClickForDoubleTapDelay { 350 };

Nit - Seconds

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:809
> +    auto distanceBetweenTaps = sqrtf(pow(m_potentialTapLocation.x() - m_lastCommittedTapLocation.x(), 2) + pow(m_potentialTapLocation.y() - m_lastCommittedTapLocation.y(), 2));

Nit - you could probably just subtract the points and use diagonalLengthSquared.

[zalan]

Created attachment 371881 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 371881 [details]
Patch

Clearing flags on attachment: 371881

Committed r246347: <https://trac.webkit.org/changeset/246347>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51654009>

[Alexey Proskuryakov]

Impressive!

Do any TestExpectations files need to be updated? Can’t check them now myself.

[zalan]

(In reply to Alexey Proskuryakov from comment #7)
> Impressive!
> 
> Do any TestExpectations files need to be updated? Can’t check them now
> myself.
Oh, right! I'll take a look and will update them.