Bug 198764

Summary:

LayoutTests/fast/events/touch/ios/double-tap-for-double-click* test cases are failing

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

alan

Reported 2019-06-11 13:07:02 PDT

<rdar://problem/51035459>

Attachments
Patch (31.35 KB, patch) 2019-06-11 13:16 PDT, alan	no flags	Details Formatted Diff Diff
Patch (32.13 KB, patch) 2019-06-11 14:53 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2019-06-11 13:16:32 PDT

Created attachment 371871 [details] Patch

Wenson Hsieh

Comment 2 2019-06-11 13:28:45 PDT

Comment on attachment 371871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371871&action=review r=mews > Source/WebKit/Shared/WebPageCreationParameters.cpp:295 > + if (!decoder.decode(parameters.doubleClickForDoubleTapDelay)) Nit - doubleTapForDoubleClick* sounds a bit more appropriate. > Source/WebKit/Shared/WebPageCreationParameters.h:161 > + double doubleClickForDoubleTapDelay { 350 }; Nit - Seconds > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:809 > + auto distanceBetweenTaps = sqrtf(pow(m_potentialTapLocation.x() - m_lastCommittedTapLocation.x(), 2) + pow(m_potentialTapLocation.y() - m_lastCommittedTapLocation.y(), 2)); Nit - you could probably just subtract the points and use diagonalLengthSquared.

alan

Comment 3 2019-06-11 14:53:15 PDT

Created attachment 371881 [details] Patch

WebKit Commit Bot

Comment 4 2019-06-11 21:13:42 PDT

Comment on attachment 371881 [details] Patch Clearing flags on attachment: 371881 Committed r246347: <https://trac.webkit.org/changeset/246347>

WebKit Commit Bot

Comment 5 2019-06-11 21:13:44 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2019-06-11 21:14:21 PDT

<rdar://problem/51654009>

Alexey Proskuryakov

Comment 7 2019-06-12 02:17:49 PDT

Impressive! Do any TestExpectations files need to be updated? Can’t check them now myself.

alan

Comment 8 2019-06-12 06:30:47 PDT

(In reply to Alexey Proskuryakov from comment #7) > Impressive! > > Do any TestExpectations files need to be updated? Can’t check them now > myself. Oh, right! I'll take a look and will update them.

Note You need to log in before you can comment on or make changes to this bug.