Bug 198722

Summary: [JSC] Linker fails when unified sources are not in use
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198752    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch v2 none

Description Adrian Perez 2019-06-10 09:03:23 PDT 
Configuring the GTK port with unified sources disabled (by passing
-DENABLE_UNIFIED_BUILDS=OFF to CMake) results in a long linker error
which is caused by some .cpp files missing needed #includes for some
headers that define inline functions.

---

% samu -j33 jsc
samu: job failed: : && /usr/lib/ccache/bin/c++  -fdiagnostics-color=always -Wextra -Wall -Wno-expansion-to-defined -Wno-psabi -Wno-noexcept-type -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align  -fno-strict-aliasing -fno-exceptions -fno-rtti -std=c++17 -O3 -DNDEBUG  -fuse-ld=gold -Wl,--disable-new-dtags Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/__/jsc.cpp.o  -o bin/jsc  -ldl /usr/lib/libglib-2.0.so /usr/lib/libgmodule-2.0.so lib/libJavaScriptCore.a /usr/lib/libgmodule-2.0.so lib/libWTF.a lib/libbmalloc.a /usr/lib/libicudata.so /usr/lib/libicui18n.so /usr/lib/libicuuc.so -ldl -lpthread /usr/lib/libgio-2.0.so /usr/lib/libgobject-2.0.so /usr/lib/libglib-2.0.so /usr/lib/libz.so && :
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/ftl/FTLCompile.cpp.o):FTLCompile.cpp:function _ZZZN3JSC3FTL7compileERNS0_5StateERNS_3DFG9Safepoint6ResultEENKUlPNS_2B35ValueEE1_clES9_ENKUlT_S9_E_clISt17reference_wrapperIKN3WTF16RecursableLambdaISC_EEEEEvSB_S9_: error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/ftl/FTLCompile.cpp.o):FTLCompile.cpp:function _ZZZN3JSC3FTL7compileERNS0_5StateERNS_3DFG9Safepoint6ResultEENKUlPNS_2B35ValueEE1_clES9_ENKUlT_S9_E_clISt17reference_wrapperIKN3WTF16RecursableLambdaISC_EEEEEvSB_S9_: error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/ftl/FTLCompile.cpp.o):FTLCompile.cpp:function _ZZZN3JSC3FTL7compileERNS0_5StateERNS_3DFG9Safepoint6ResultEENKUlPNS_2B35ValueEE1_clES9_ENKUlT_S9_E_clISt17reference_wrapperIKN3WTF16RecursableLambdaISC_EEEEEvSB_S9_: error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmSectionParser.cpp.o):WasmSectionParser.cpp:function JSC::Wasm::SectionParser::parseInitExpr(unsigned char&, unsigned long&, JSC::Wasm::Type&): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmSectionParser.cpp.o):WasmSectionParser.cpp:function JSC::Wasm::SectionParser::parseInitExpr(unsigned char&, unsigned long&, JSC::Wasm::Type&): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::JSValue()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::visitChildren(JSC::SlotVisitor&): error: undefined reference to 'JSC::JSCellLock::lock()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::visitChildren(JSC::SlotVisitor&): error: undefined reference to 'void JSC::SlotVisitor::append<JSC::Unknown, WTF::DumbValueTraits<JSC::Unknown> >(JSC::WriteBarrierBase<JSC::Unknown, WTF::DumbValueTraits<JSC::Unknown> > const&)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::clear(unsigned int): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::clear(unsigned int): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::set(unsigned int, JSC::JSValue): error: undefined reference to 'JSC::HeapCell::vm() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::grow(unsigned int): error: undefined reference to 'JSC::JSCellLock::lock()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::grow(unsigned int): error: undefined reference to 'JSC::JSValue::JSValue()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::FuncRefTable::setFunction(unsigned int, JSC::JSObject*, JSC::Wasm::WasmToWasmImportableFunction, JSC::Wasm::Instance*): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSCell*)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::FuncRefTable::setFunction(unsigned int, JSC::JSObject*, JSC::Wasm::WasmToWasmImportableFunction, JSC::Wasm::Instance*): error: undefined reference to 'JSC::HeapCell::vm() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::get(unsigned int) const: error: undefined reference to 'JSC::JSValue::decode(long)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmValidate.cpp.o):WasmValidate.cpp:function JSC::Wasm::FunctionParser<JSC::Wasm::Validate>::parseExpression(): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/b3/B3LowerMacrosAfterOptimizations.cpp.o):B3LowerMacrosAfterOptimizations.cpp:function JSC::B3::(anonymous namespace)::lowerMacrosImpl(JSC::B3::Procedure&): error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/b3/B3PureCSE.cpp.o):B3PureCSE.cpp:function JSC::B3::PureCSE::process(JSC::B3::Value*, JSC::B3::Dominators&): error: undefined reference to 'JSC::B3::Value::isConstant() const'
collect2: error: ld returned 1 exit status
samu: job failed: : && /usr/lib/ccache/bin/c++  -fdiagnostics-color=always -Wextra -Wall -Wno-expansion-to-defined -Wno-psabi -Wno-noexcept-type -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align  -fno-strict-aliasing -fno-exceptions -fno-rtti -std=c++17 -O3 -DNDEBUG  -fuse-ld=gold -Wl,--disable-new-dtags Source/JavaScriptCore/shell/CMakeFiles/testmasm.dir/__/assembler/testmasm.cpp.o  -o bin/testmasm  lib/libJavaScriptCore.a lib/libWTF.a lib/libbmalloc.a /usr/lib/libicudata.so /usr/lib/libicui18n.so /usr/lib/libicuuc.so -ldl -lpthread /usr/lib/libgio-2.0.so /usr/lib/libgobject-2.0.so /usr/lib/libz.so /usr/lib/libglib-2.0.so /usr/lib/libgmodule-2.0.so && :
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/ftl/FTLCompile.cpp.o):FTLCompile.cpp:function _ZZZN3JSC3FTL7compileERNS0_5StateERNS_3DFG9Safepoint6ResultEENKUlPNS_2B35ValueEE1_clES9_ENKUlT_S9_E_clISt17reference_wrapperIKN3WTF16RecursableLambdaISC_EEEEEvSB_S9_: error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/ftl/FTLCompile.cpp.o):FTLCompile.cpp:function _ZZZN3JSC3FTL7compileERNS0_5StateERNS_3DFG9Safepoint6ResultEENKUlPNS_2B35ValueEE1_clES9_ENKUlT_S9_E_clISt17reference_wrapperIKN3WTF16RecursableLambdaISC_EEEEEvSB_S9_: error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/ftl/FTLCompile.cpp.o):FTLCompile.cpp:function _ZZZN3JSC3FTL7compileERNS0_5StateERNS_3DFG9Safepoint6ResultEENKUlPNS_2B35ValueEE1_clES9_ENKUlT_S9_E_clISt17reference_wrapperIKN3WTF16RecursableLambdaISC_EEEEEvSB_S9_: error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmSectionParser.cpp.o):WasmSectionParser.cpp:function JSC::Wasm::SectionParser::parseInitExpr(unsigned char&, unsigned long&, JSC::Wasm::Type&): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmSectionParser.cpp.o):WasmSectionParser.cpp:function JSC::Wasm::SectionParser::parseInitExpr(unsigned char&, unsigned long&, JSC::Wasm::Type&): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::JSValue()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::visitChildren(JSC::SlotVisitor&): error: undefined reference to 'JSC::JSCellLock::lock()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::visitChildren(JSC::SlotVisitor&): error: undefined reference to 'void JSC::SlotVisitor::append<JSC::Unknown, WTF::DumbValueTraits<JSC::Unknown> >(JSC::WriteBarrierBase<JSC::Unknown, WTF::DumbValueTraits<JSC::Unknown> > const&)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::clear(unsigned int): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::clear(unsigned int): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::set(unsigned int, JSC::JSValue): error: undefined reference to 'JSC::HeapCell::vm() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::grow(unsigned int): error: undefined reference to 'JSC::JSCellLock::lock()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::grow(unsigned int): error: undefined reference to 'JSC::JSValue::JSValue()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::FuncRefTable::setFunction(unsigned int, JSC::JSObject*, JSC::Wasm::WasmToWasmImportableFunction, JSC::Wasm::Instance*): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSCell*)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::FuncRefTable::setFunction(unsigned int, JSC::JSObject*, JSC::Wasm::WasmToWasmImportableFunction, JSC::Wasm::Instance*): error: undefined reference to 'JSC::HeapCell::vm() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::get(unsigned int) const: error: undefined reference to 'JSC::JSValue::decode(long)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmValidate.cpp.o):WasmValidate.cpp:function JSC::Wasm::FunctionParser<JSC::Wasm::Validate>::parseExpression(): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/b3/B3LowerMacrosAfterOptimizations.cpp.o):B3LowerMacrosAfterOptimizations.cpp:function JSC::B3::(anonymous namespace)::lowerMacrosImpl(JSC::B3::Procedure&): error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/b3/B3PureCSE.cpp.o):B3PureCSE.cpp:function JSC::B3::PureCSE::process(JSC::B3::Value*, JSC::B3::Dominators&): error: undefined reference to 'JSC::B3::Value::isConstant() const'
collect2: error: ld returned 1 exit status
samu: job failed: : && /usr/lib/ccache/bin/c++  -fdiagnostics-color=always -Wextra -Wall -Wno-expansion-to-defined -Wno-psabi -Wno-noexcept-type -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align  -fno-strict-aliasing -fno-exceptions -fno-rtti -std=c++17 -O3 -DNDEBUG  -fuse-ld=gold -Wl,--disable-new-dtags Source/JavaScriptCore/shell/CMakeFiles/testapi.dir/__/API/tests/CompareAndSwapTest.cpp.o Source/JavaScriptCore/shell/CMakeFiles/testapi.dir/__/API/tests/CustomGlobalObjectClassTest.c.o Source/JavaScriptCore/shell/CMakeFiles/testapi.dir/__/API/tests/ExecutionTimeLimitTest.cpp.o Source/JavaScriptCore/shell/CMakeFiles/testapi.dir/__/API/tests/FunctionOverridesTest.cpp.o Source/JavaScriptCore/shell/CMakeFiles/testapi.dir/__/API/tests/GlobalContextWithFinalizerTest.cpp.o Source/JavaScriptCore/shell/CMakeFiles/testapi.dir/__/API/tests/JSONParseTest.cpp.o Source/JavaScriptCore/shell/CMakeFiles/testapi.dir/__/API/tests/JSObjectGetProxyTargetTest.cpp.o Source/JavaScriptCore/shell/CMakeFiles/testapi.dir/__/API/tests/MultithreadedMultiVMExecutionTest.cpp.o Source/JavaScriptCore/shell/CMakeFiles/testapi.dir/__/API/tests/PingPongStackOverflowTest.cpp.o Source/JavaScriptCore/shell/CMakeFiles/testapi.dir/__/API/tests/TypedArrayCTest.cpp.o Source/JavaScriptCore/shell/CMakeFiles/testapi.dir/__/API/tests/testapi.c.o Source/JavaScriptCore/shell/CMakeFiles/testapi.dir/__/API/tests/testapi.cpp.o  -o bin/testapi  lib/libJavaScriptCore.a lib/libWTF.a lib/libbmalloc.a /usr/lib/libicudata.so /usr/lib/libicui18n.so /usr/lib/libicuuc.so -ldl -lpthread /usr/lib/libgio-2.0.so /usr/lib/libgobject-2.0.so /usr/lib/libz.so /usr/lib/libglib-2.0.so /usr/lib/libgmodule-2.0.so && :
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/ftl/FTLCompile.cpp.o):FTLCompile.cpp:function _ZZZN3JSC3FTL7compileERNS0_5StateERNS_3DFG9Safepoint6ResultEENKUlPNS_2B35ValueEE1_clES9_ENKUlT_S9_E_clISt17reference_wrapperIKN3WTF16RecursableLambdaISC_EEEEEvSB_S9_: error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/ftl/FTLCompile.cpp.o):FTLCompile.cpp:function _ZZZN3JSC3FTL7compileERNS0_5StateERNS_3DFG9Safepoint6ResultEENKUlPNS_2B35ValueEE1_clES9_ENKUlT_S9_E_clISt17reference_wrapperIKN3WTF16RecursableLambdaISC_EEEEEvSB_S9_: error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/ftl/FTLCompile.cpp.o):FTLCompile.cpp:function _ZZZN3JSC3FTL7compileERNS0_5StateERNS_3DFG9Safepoint6ResultEENKUlPNS_2B35ValueEE1_clES9_ENKUlT_S9_E_clISt17reference_wrapperIKN3WTF16RecursableLambdaISC_EEEEEvSB_S9_: error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmSectionParser.cpp.o):WasmSectionParser.cpp:function JSC::Wasm::SectionParser::parseInitExpr(unsigned char&, unsigned long&, JSC::Wasm::Type&): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmSectionParser.cpp.o):WasmSectionParser.cpp:function JSC::Wasm::SectionParser::parseInitExpr(unsigned char&, unsigned long&, JSC::Wasm::Type&): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::JSValue()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::visitChildren(JSC::SlotVisitor&): error: undefined reference to 'JSC::JSCellLock::lock()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::visitChildren(JSC::SlotVisitor&): error: undefined reference to 'void JSC::SlotVisitor::append<JSC::Unknown, WTF::DumbValueTraits<JSC::Unknown> >(JSC::WriteBarrierBase<JSC::Unknown, WTF::DumbValueTraits<JSC::Unknown> > const&)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::clear(unsigned int): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::clear(unsigned int): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::set(unsigned int, JSC::JSValue): error: undefined reference to 'JSC::HeapCell::vm() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::grow(unsigned int): error: undefined reference to 'JSC::JSCellLock::lock()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::grow(unsigned int): error: undefined reference to 'JSC::JSValue::JSValue()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::FuncRefTable::setFunction(unsigned int, JSC::JSObject*, JSC::Wasm::WasmToWasmImportableFunction, JSC::Wasm::Instance*): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSCell*)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::FuncRefTable::setFunction(unsigned int, JSC::JSObject*, JSC::Wasm::WasmToWasmImportableFunction, JSC::Wasm::Instance*): error: undefined reference to 'JSC::HeapCell::vm() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::get(unsigned int) const: error: undefined reference to 'JSC::JSValue::decode(long)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmValidate.cpp.o):WasmValidate.cpp:function JSC::Wasm::FunctionParser<JSC::Wasm::Validate>::parseExpression(): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/b3/B3LowerMacrosAfterOptimizations.cpp.o):B3LowerMacrosAfterOptimizations.cpp:function JSC::B3::(anonymous namespace)::lowerMacrosImpl(JSC::B3::Procedure&): error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/b3/B3PureCSE.cpp.o):B3PureCSE.cpp:function JSC::B3::PureCSE::process(JSC::B3::Value*, JSC::B3::Dominators&): error: undefined reference to 'JSC::B3::Value::isConstant() const'
collect2: error: ld returned 1 exit status
samu: job failed: : && /usr/lib/ccache/bin/c++  -fdiagnostics-color=always -Wextra -Wall -Wno-expansion-to-defined -Wno-psabi -Wno-noexcept-type -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align  -fno-strict-aliasing -fno-exceptions -fno-rtti -std=c++17 -O3 -DNDEBUG  -fuse-ld=gold -Wl,--disable-new-dtags Source/JavaScriptCore/shell/CMakeFiles/testRegExp.dir/__/testRegExp.cpp.o  -o bin/testRegExp  lib/libJavaScriptCore.a lib/libWTF.a lib/libbmalloc.a /usr/lib/libicudata.so /usr/lib/libicui18n.so /usr/lib/libicuuc.so -ldl -lpthread /usr/lib/libgio-2.0.so /usr/lib/libgobject-2.0.so /usr/lib/libz.so /usr/lib/libglib-2.0.so /usr/lib/libgmodule-2.0.so && :
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/ftl/FTLCompile.cpp.o):FTLCompile.cpp:function _ZZZN3JSC3FTL7compileERNS0_5StateERNS_3DFG9Safepoint6ResultEENKUlPNS_2B35ValueEE1_clES9_ENKUlT_S9_E_clISt17reference_wrapperIKN3WTF16RecursableLambdaISC_EEEEEvSB_S9_: error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/ftl/FTLCompile.cpp.o):FTLCompile.cpp:function _ZZZN3JSC3FTL7compileERNS0_5StateERNS_3DFG9Safepoint6ResultEENKUlPNS_2B35ValueEE1_clES9_ENKUlT_S9_E_clISt17reference_wrapperIKN3WTF16RecursableLambdaISC_EEEEEvSB_S9_: error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/ftl/FTLCompile.cpp.o):FTLCompile.cpp:function _ZZZN3JSC3FTL7compileERNS0_5StateERNS_3DFG9Safepoint6ResultEENKUlPNS_2B35ValueEE1_clES9_ENKUlT_S9_E_clISt17reference_wrapperIKN3WTF16RecursableLambdaISC_EEEEEvSB_S9_: error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmSectionParser.cpp.o):WasmSectionParser.cpp:function JSC::Wasm::SectionParser::parseInitExpr(unsigned char&, unsigned long&, JSC::Wasm::Type&): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmSectionParser.cpp.o):WasmSectionParser.cpp:function JSC::Wasm::SectionParser::parseInitExpr(unsigned char&, unsigned long&, JSC::Wasm::Type&): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::JSValue()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::Table(unsigned int, WTF::Optional<unsigned int>, JSC::Wasm::TableElementType): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::visitChildren(JSC::SlotVisitor&): error: undefined reference to 'JSC::JSCellLock::lock()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::visitChildren(JSC::SlotVisitor&): error: undefined reference to 'void JSC::SlotVisitor::append<JSC::Unknown, WTF::DumbValueTraits<JSC::Unknown> >(JSC::WriteBarrierBase<JSC::Unknown, WTF::DumbValueTraits<JSC::Unknown> > const&)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::clear(unsigned int): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::clear(unsigned int): error: undefined reference to 'JSC::JSValue::encode(JSC::JSValue)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::set(unsigned int, JSC::JSValue): error: undefined reference to 'JSC::HeapCell::vm() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::grow(unsigned int): error: undefined reference to 'JSC::JSCellLock::lock()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::grow(unsigned int): error: undefined reference to 'JSC::JSValue::JSValue()'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::FuncRefTable::setFunction(unsigned int, JSC::JSObject*, JSC::Wasm::WasmToWasmImportableFunction, JSC::Wasm::Instance*): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSCell*)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::FuncRefTable::setFunction(unsigned int, JSC::JSObject*, JSC::Wasm::WasmToWasmImportableFunction, JSC::Wasm::Instance*): error: undefined reference to 'JSC::HeapCell::vm() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmTable.cpp.o):WasmTable.cpp:function JSC::Wasm::Table::get(unsigned int) const: error: undefined reference to 'JSC::JSValue::decode(long)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmValidate.cpp.o):WasmValidate.cpp:function JSC::Wasm::FunctionParser<JSC::Wasm::Validate>::parseExpression(): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/b3/B3LowerMacrosAfterOptimizations.cpp.o):B3LowerMacrosAfterOptimizations.cpp:function JSC::B3::(anonymous namespace)::lowerMacrosImpl(JSC::B3::Procedure&): error: undefined reference to 'JSC::B3::Value::adjacencyListOffset() const'
lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/b3/B3PureCSE.cpp.o):B3PureCSE.cpp:function JSC::B3::PureCSE::process(JSC::B3::Value*, JSC::B3::Dominators&): error: undefined reference to 'JSC::B3::Value::isConstant() const'
collect2: error: ld returned 1 exit status
samu: subcommands failed
Comment 1 Adrian Perez 2019-06-10 09:10:50 PDT 
Created attachment 371752 [details]
Patch
Comment 2 Keith Miller 2019-06-10 09:12:03 PDT 
Comment on attachment 371752 [details]
Patch

r=me.
Comment 3 WebKit Commit Bot 2019-06-10 09:15:00 PDT 
Comment on attachment 371752 [details]
Patch

Rejecting attachment 371752 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 371752, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/12434658
Comment 4 Adrian Perez 2019-06-10 09:33:29 PDT 
Created attachment 371754 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-06-10 10:16:23 PDT 
Comment on attachment 371754 [details]
Patch for landing

Clearing flags on attachment: 371754

Committed r246266: <https://trac.webkit.org/changeset/246266>
Comment 6 WebKit Commit Bot 2019-06-10 10:16:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-06-10 10:17:20 PDT 
<rdar://problem/51585733>
Comment 8 Adrian Perez 2019-06-19 05:07:10 PDT 
Reopening to attach new patch.
Comment 9 Adrian Perez 2019-06-19 05:07:13 PDT 
Created attachment 372452 [details]
Patch v2


Should fix the Mac build issue, and adds a few more fixes needed
for non-unified builds to complete successfully.
Comment 10 Adrian Perez 2019-06-19 05:08:03 PDT 
Comment on attachment 372452 [details]
Patch v2

Patch attached to wrong bug, obsoleting.