Summary: | [WHLSL] Remove unnecessary ASSERT()s and clean up visitor lambdas | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||
Component: | WebGPU | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dino, fpizlo, jonlee, justin_fan, rmorisset, saam, webkit-bug-importer | ||||||||
Priority: | P1 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 198704 | ||||||||||
Attachments: |
|
Description
Myles C. Maxfield
2019-06-09 23:38:45 PDT
Created attachment 371724 [details]
WIP
*** Bug 198705 has been marked as a duplicate of this bug. *** Changing to P1 since it blocks 198704. Created attachment 372022 [details]
Patch
Created attachment 372066 [details]
Patch
LGTM too. Comment on attachment 372066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372066&action=review r=me with just a nitpick. > Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp:350 > + auto textureTypeIndex = std::find(m_textureTypeNames, m_textureTypeNames + WTF_ARRAY_LENGTH(m_textureTypeNames), nativeTypeDeclaration.name()) - m_textureTypeNames; I understand that is more concise, but I am not entirely comfortable with replacing some reasonable code by pointer arithmetic (the - m_textureTypeNames at the end). It gets me especially wary because of the auto. Is this std::ptrdiff_t ?uintptr_t ? Committed r246428: <https://trac.webkit.org/changeset/246428> |