Bug 198618 – [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify SecurityOrigin with non-default port number

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Daniel Bates]

When debugging a document whose URL contains a non-default port (e.g. example.com:8800) the LLDB pretty-printer died with the following trace:

Traceback (most recent call last):
  File "/Volumes/Data/.../Tools/lldb/lldb_webkit.py", line 231, in WebCoreSecurityOrigin_SummaryProvider
    return '{ %s, domain = %s, hasUniversalAccess = %d }' % (provider.to_string(), provider.domain(), provider.has_universal_access())
  File "/Volumes/Data/.../Tools/lldb/lldb_webkit.py", line 694, in to_string
    result += ':' + port
TypeError: cannot concatenate 'str' and 'int' objects

[Daniel Bates]

Created attachment 371518 [details]
Patch

[Daniel Bates]

Cannot write a test for this without building WebCore every time you run test-webkitpy. We need to land bug #187916 to be able to write such tests.

[Brent Fulgham]

Comment on attachment 371518 [details]
Patch

Perl wouldn't make you do these manual type conversions! :-) r=me

[Daniel Bates]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 371518 [details]
> Patch
> 
> Perl wouldn't make you do these manual type conversions! :-) r=me

I know!!! <-- That's why I like Perl so much 😀

[Daniel Bates]

Committed r246164: <https://trac.webkit.org/changeset/246164>

[Radar WebKit Bug Importer]

<rdar://problem/51494693>