Bug 198597 – Don't expose negative scrollLeft/scrollTop during rubber-banding

• Component: Scrolling
• Status: NEW

[Simon Fraser (smfr)]

Don't expose negative scrollLeft/scrollTop during rubber-banding

[Simon Fraser (smfr)]

Created attachment 371468 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/51467217>

[Antti Koivisto]

Comment on attachment 371468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371468&action=review

> Source/WebCore/platform/ScrollView.h:224
> +    WEBCORE_EXPORT ScrollPosition scrollPosition(ScrollClamping = ScrollClamping::Unclamped) const final;

Alternatively these functions could return both clamped and unclamped values as a struct, avoiding parameter passing.

[Simon Fraser (smfr)]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 371468 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371468&action=review
> 
> > Source/WebCore/platform/ScrollView.h:224
> > +    WEBCORE_EXPORT ScrollPosition scrollPosition(ScrollClamping = ScrollClamping::Unclamped) const final;
> 
> Alternatively these functions could return both clamped and unclamped values
> as a struct, avoiding parameter passing.

I think that would be even more plumbing.

I'm worried that this isn't web compatible, so I'll hold off on landing this.

[Simon Fraser (smfr)]

Comment on attachment 371468 [details]
Patch

Not going to land until I'm more convinced this won't break things.