Bug 198591

Summary: [WebGPU] Remove GPUBuffer.setSubData and implement GPUDevice.createBufferMapped
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: New BugsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, kondapallykalyan, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Justin Fan
Reported 2019-06-05 18:06:14 PDT
[WebGPU] Remove GPUBuffer.setSubData and implement GPUDevice.createBufferMapped
Attachments
Patch (38.91 KB, patch)
2019-06-05 18:52 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2019-06-05 18:06:41 PDT
<rdar://problem/50951309>
Justin Fan
Comment 2 2019-06-05 18:52:16 PDT
Created attachment 371464 [details] Patch
Myles C. Maxfield
Comment 3 2019-06-07 15:00:11 PDT
Comment on attachment 371464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371464&action=review > Source/WebCore/platform/graphics/gpu/cocoa/GPUBufferMetal.mm:226 > + if (!m_device->tryGetQueue() || !(queue = m_device->tryGetQueue()->platformQueue())) The group will investigate and probably add the idea of multiple queues. We should figure out how this will work in that world. > Source/WebCore/platform/graphics/gpu/cocoa/GPUBufferMetal.mm:233 > + stagingMtlBuffer = adoptNS([m_device->platformDevice() newBufferWithLength:static_cast<NSUInteger>(m_byteLength) options:MTLResourceCPUCacheModeDefaultCache]); Can we cache these somehow? It seems silly to continually create and destroy these.
WebKit Commit Bot
Comment 4 2019-06-07 15:25:01 PDT
Comment on attachment 371464 [details] Patch Clearing flags on attachment: 371464 Committed r246217: <https://trac.webkit.org/changeset/246217>
WebKit Commit Bot
Comment 5 2019-06-07 15:25:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.