Bug 198590

Summary: Introduce new SPI for context menus on iOS
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit APIAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, dino, thorton, timothy, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Alex Christensen 2019-06-05 17:20:27 PDT 
Introduce new SPI for context menus on iOS
Comment 1 Alex Christensen 2019-06-05 17:23:14 PDT 
Created attachment 371457 [details]
Patch
Comment 2 Alex Christensen 2019-06-05 17:34:00 PDT 
Created attachment 371458 [details]
Patch
Comment 3 Tim Horton 2019-06-05 17:35:09 PDT 
Comment on attachment 371457 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371457&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:148
> +// This needs to be kept once there is an API version to allow notifications for images.

"notifications"?

> Source/WebKit/UIProcess/API/Cocoa/_WKActivatedElementInfo.mm:54
> +    BOOL _isAnimatedImage;

I think the member usually drops the is?
Comment 4 Alex Christensen 2019-06-05 17:40:41 PDT 
Created attachment 371459 [details]
Patch
Comment 5 Alex Christensen 2019-06-05 17:55:51 PDT 
Created attachment 371461 [details]
Patch
Comment 6 Alex Christensen 2019-06-05 19:11:03 PDT 
http://trac.webkit.org/r246137
Comment 7 Radar WebKit Bug Importer 2019-06-05 19:14:13 PDT 
<rdar://problem/51466257>
Comment 8 Truitt Savell 2019-06-06 09:50:53 PDT 
Reverted r246137 for reason:

Broke internal builds.

Committed r246157: <https://trac.webkit.org/changeset/246157>
Comment 9 Timothy Hatcher 2019-06-06 17:23:52 PDT 
<rdar://problem/51462498>
Comment 10 Alex Christensen 2019-06-17 15:29:53 PDT 
This was relanded in https://trac.webkit.org/changeset/246224/webkit