Bug 198563

Summary: [JSCOnly] JSCOnly port is not building on macOS
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, don.olmstead, ews-watchlist, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Caio Lima 2019-06-05 05:49:55 PDT
After https://trac.webkit.org/changeset/245492, build JSCOnly port on mac results in the following build error:

```
CMake Error at Source/cmake/OptionsJSCOnly.cmake:102 (include):
  include could not find load file:

    target/icu.cmake
Call Stack (most recent call first):
  Source/cmake/WebKitCommon.cmake:56 (include)
  CMakeLists.txt:168 (include)


-- Platform-specific CMakeLists not found: /Source/webkit/Source/bmalloc/PlatformJSCOnly.cmake
-- Using platform-specific CMakeLists: /Source/webkit/Source/WTF/wtf/PlatformJSCOnly.cmake
CMake Error at Source/WTF/CMakeLists.txt:10 (file):
  file COPY given no DESTINATION
```
Comment 1 Don Olmstead 2019-06-05 14:13:25 PDT
Maybe fixed in https://bugs.webkit.org/show_bug.cgi?id=197132 ?
Comment 2 Caio Lima 2019-06-05 15:44:27 PDT
(In reply to Don Olmstead from comment #1)
> Maybe fixed in https://bugs.webkit.org/show_bug.cgi?id=197132 ?

It does, indeed. Thx! I just found another issue but I have a patch already.
Comment 3 Caio Lima 2019-06-05 16:01:10 PDT
Created attachment 371444 [details]
Patch
Comment 4 Caio Lima 2019-06-05 16:03:04 PDT
Current failure is:

```
FAILED: Source/WTF/wtf/CMakeFiles/WTF.dir/WTFAssertions.cpp.o 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -DBUILDING_JSCONLY__ -DBUILDING_WITH_CMAKE=1 -DBUILDING_WTF -DHAVE_CONFIG_H=1 -DU_DISABLE_RENAMING=1 -DU_SHOW_CPLUSPLUS_API=0 -I. -IDerivedSources -I../../Source/ThirdParty -IDerivedSources/WTF -I../../Source/WTF -I../../Source/WTF/wtf -I../../Source/WTF/wtf/dtoa -I../../Source/WTF/wtf/persistence -I../../Source/WTF/wtf/text -I../../Source/WTF/wtf/text/icu -I../../Source/WTF/wtf/threads -I../../Source/WTF/wtf/unicode -IDerivedSources/ForwardingHeaders -isystem ICU/Headers -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -Wno-parentheses-equality -Wno-noexcept-type -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align  -fno-strict-aliasing -fno-exceptions -fno-rtti -std=c++17 -O3 -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -fPIC -MD -MT Source/WTF/wtf/CMakeFiles/WTF.dir/WTFAssertions.cpp.o -MF Source/WTF/wtf/CMakeFiles/WTF.dir/WTFAssertions.cpp.o.d -o Source/WTF/wtf/CMakeFiles/WTF.dir/WTFAssertions.cpp.o -c ../../Source/WTF/wtf/WTFAssertions.cpp
../../Source/WTF/wtf/WTFAssertions.cpp:52:15: error: use of undeclared identifier 'mach_vm_offset_t'
static_assert(MACH_VM_MAX_ADDRESS <= ((1ULL << WTF_CPU_EFFECTIVE_ADDRESS_WIDTH) - 1));
              ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/i386/vm_param.h:161:43: note: expanded from macro 'MACH_VM_MAX_ADDRESS'
#define MACH_VM_MAX_ADDRESS             ((mach_vm_offset_t) VM_MAX_PAGE_ADDRESS)
```
Comment 5 Caio Lima 2019-06-06 01:28:47 PDT
Thx for the review!
Comment 6 WebKit Commit Bot 2019-06-06 01:58:10 PDT
Comment on attachment 371444 [details]
Patch

Clearing flags on attachment: 371444

Committed r246146: <https://trac.webkit.org/changeset/246146>
Comment 7 WebKit Commit Bot 2019-06-06 01:58:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-06-06 01:59:21 PDT
<rdar://problem/51474999>