Bug 198551

Summary:

Remove SSL-based tests from TestWebKitAPI on some configurations

Product:

WebKit

Reporter:

Keith Rollin <krollin>

Component:

Tools / Tests

Assignee:

Keith Rollin <krollin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, dbates, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Keith Rollin

Reported 2019-06-04 19:12:31 PDT

TestWebKitAPI doesn't build on all configurations and is not used on all configurations. It doesn't build on tvOS simulator due to missing SSL functions. And it's not (yet) utilized on actual embedded devices. In light of all this, only build TestWebKitAPI on macOS, iOS Simulator, and watchOS simulator.

Attachments
Patch (1.82 KB, patch) 2019-06-04 19:14 PDT, Keith Rollin	no flags	Details Formatted Diff Diff
Patch (1.48 KB, patch) 2019-06-05 10:37 PDT, Keith Rollin	no flags	Details Formatted Diff Diff
Patch (4.81 KB, patch) 2019-06-06 12:49 PDT, Keith Rollin	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-06-04 19:12:44 PDT

<rdar://problem/51424996>

Keith Rollin

Comment 2 2019-06-04 19:14:39 PDT

Created attachment 371362 [details] Patch

Jonathan Bedard

Comment 3 2019-06-05 08:35:31 PDT

Comment on attachment 371362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371362&action=review > Tools/Makefile:7 > + ifneq (,$(findstring simulator,$(SDKROOT))) # Include TestWebKitAPI for simulators... We do build TestWebKitAPI for embedded devices now...I'd be curious if you encountered problems doing so.

Keith Rollin

Comment 4 2019-06-05 10:30:52 PDT

tvOS has the same issue as tvSimulator. So should we just prevent tvOS/Simulator from building TestWebKitAPI?

Keith Rollin

Comment 5 2019-06-05 10:37:53 PDT

Created attachment 371419 [details] Patch

Chris Dumez

Comment 6 2019-06-05 10:49:36 PDT

Comment on attachment 371419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371419&action=review > Tools/Makefile:7 > + ifeq (,$(findstring appletv,$(SDKROOT))) # Don't build TestWebKitAPI on AppleTV, due to missing SSL support Alex, isn't this just your new test server? Can we just disable Alex's new test server for Apple TV. Disabling building ALL tests seems aggressive.

Alex Christensen

Comment 7 2019-06-05 10:55:05 PDT

Comment on attachment 371419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371419&action=review >> Tools/Makefile:7 >> + ifeq (,$(findstring appletv,$(SDKROOT))) # Don't build TestWebKitAPI on AppleTV, due to missing SSL support > > Alex, isn't this just your new test server? Can we just disable Alex's new test server for Apple TV. Disabling building ALL tests seems aggressive. We could either build libwebrtc's boringssl on AppleTV and link with it, or we could just add preprocessor macros to all use of TCPServer in TestWebKitAPI. I agree, disabling all tests would be a bad thing.

Keith Rollin

Comment 8 2019-06-05 10:56:09 PDT

(In reply to Alex Christensen from comment #7) > we could just add preprocessor macros to all use of TCPServer in > TestWebKitAPI. I agree, disabling all tests would be a bad thing. I'll look into this one.

Keith Rollin

Comment 9 2019-06-06 12:49:28 PDT

Created attachment 371521 [details] Patch

WebKit Commit Bot

Comment 10 2019-06-06 15:34:56 PDT

Comment on attachment 371521 [details] Patch Clearing flags on attachment: 371521 Committed r246173: <https://trac.webkit.org/changeset/246173>

WebKit Commit Bot

Comment 11 2019-06-06 15:34:58 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.