Bug 198548

Summary: Use an enumeration in UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo callback
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch for landing
none
Fix WPE build youennf: commit-queue+

youenn fablet
Reported 2019-06-04 16:28:12 PDT
This will make code more readable
Attachments
Patch (12.73 KB, patch)
2019-06-04 16:37 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (12.73 KB, patch)
2019-06-04 20:09 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (12.73 KB, patch)
2019-06-04 20:22 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.55 MB, application/zip)
2019-06-04 22:05 PDT, EWS Watchlist 		no flags
Details
Patch for landing (13.73 KB, patch)
2019-06-05 11:27 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fix WPE build (13.87 KB, patch)
2019-06-06 09:03 PDT, youenn fablet 		youennf: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-06-04 16:37:40 PDT
Created attachment 371351 [details] Patch
youenn fablet
Comment 2 2019-06-04 20:09:13 PDT
Created attachment 371366 [details] Patch
youenn fablet
Comment 3 2019-06-04 20:22:27 PDT
Created attachment 371370 [details] Patch
EWS Watchlist
Comment 4 2019-06-04 22:04:59 PDT
Comment on attachment 371370 [details] Patch Attachment 371370 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12380991 New failing tests: http/tests/cache/disk-cache/redirect-chain-limits.html
EWS Watchlist
Comment 5 2019-06-04 22:05:00 PDT
Created attachment 371376 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
youenn fablet
Comment 6 2019-06-05 08:43:34 PDT
Comment on attachment 371370 [details] Patch iOS-sim failed test is unrelated to this patch. api-mac unit test is also unrelated. win build issue also
Eric Carlson
Comment 7 2019-06-05 10:05:33 PDT
Comment on attachment 371370 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371370&action=review > Source/WebKit/UIProcess/UserMediaPermissionCheckProxy.h:41 > + enum class PermissionInfo { Error, NoAccess, PersistentAccess }; Nit: "NoAccess" isn't quite right, the user needs to be asked. Maybe "RequirePrompt", or "PromptUser" instead?
youenn fablet
Comment 8 2019-06-05 11:17:18 PDT
(In reply to Eric Carlson from comment #7) > Comment on attachment 371370 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371370&action=review > > > Source/WebKit/UIProcess/UserMediaPermissionCheckProxy.h:41 > > + enum class PermissionInfo { Error, NoAccess, PersistentAccess }; > > Nit: "NoAccess" isn't quite right, the user needs to be asked. Maybe > "RequirePrompt", or "PromptUser" instead? I went with Unknown and Granted instead of NoAccess and PersistentAccess.
youenn fablet
Comment 9 2019-06-05 11:27:41 PDT
Created attachment 371424 [details] Patch for landing
youenn fablet
Comment 10 2019-06-06 09:03:46 PDT
Created attachment 371501 [details] Fix WPE build
WebKit Commit Bot
Comment 11 2019-06-06 20:29:06 PDT
Comment on attachment 371501 [details] Fix WPE build Clearing flags on attachment: 371501 Committed r246185: <https://trac.webkit.org/changeset/246185>
WebKit Commit Bot
Comment 12 2019-06-06 20:29:08 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2019-06-06 20:33:00 PDT
<rdar://problem/51510298>
Note You need to log in before you can comment on or make changes to this bug.