| Summary: | Use an enumeration in UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo callback | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer, youennf | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
youenn fablet
2019-06-04 16:28:12 PDT
Created attachment 371351 [details]
Patch
Created attachment 371366 [details]
Patch
Created attachment 371370 [details]
Patch
Comment on attachment 371370 [details] Patch Attachment 371370 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12380991 New failing tests: http/tests/cache/disk-cache/redirect-chain-limits.html Created attachment 371376 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Comment on attachment 371370 [details]
Patch
iOS-sim failed test is unrelated to this patch.
api-mac unit test is also unrelated.
win build issue also
Comment on attachment 371370 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371370&action=review > Source/WebKit/UIProcess/UserMediaPermissionCheckProxy.h:41 > + enum class PermissionInfo { Error, NoAccess, PersistentAccess }; Nit: "NoAccess" isn't quite right, the user needs to be asked. Maybe "RequirePrompt", or "PromptUser" instead? (In reply to Eric Carlson from comment #7) > Comment on attachment 371370 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371370&action=review > > > Source/WebKit/UIProcess/UserMediaPermissionCheckProxy.h:41 > > + enum class PermissionInfo { Error, NoAccess, PersistentAccess }; > > Nit: "NoAccess" isn't quite right, the user needs to be asked. Maybe > "RequirePrompt", or "PromptUser" instead? I went with Unknown and Granted instead of NoAccess and PersistentAccess. Created attachment 371424 [details]
Patch for landing
Created attachment 371501 [details]
Fix WPE build
Comment on attachment 371501 [details] Fix WPE build Clearing flags on attachment: 371501 Committed r246185: <https://trac.webkit.org/changeset/246185> All reviewed patches have been landed. Closing bug. |