| Summary: | Make preload/link-header-preload-imagesrcset.html work on DPR != 1 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> |
| Component: | Page Loading | Assignee: | Rob Buis <rbuis> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | beidson, commit-queue, ews-watchlist, rniwa, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=231150 | ||
| Attachments: | |||
|
Description
Rob Buis
2019-06-04 09:04:04 PDT
Created attachment 371291 [details]
Patch
Comment on attachment 371291 [details] Patch Attachment 371291 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12374598 New failing tests: imported/w3c/web-platform-tests/preload/dynamic-adding-preload-imagesrcset.html Created attachment 371311 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Created attachment 371318 [details]
Patch
Comment on attachment 371318 [details] Patch Attachment 371318 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12376547 New failing tests: imported/w3c/web-platform-tests/preload/link-header-preload-imagesrcset.html Created attachment 371328 [details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 371318 [details] Patch Attachment 371318 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12376658 New failing tests: imported/w3c/web-platform-tests/preload/dynamic-adding-preload-imagesrcset.html imported/w3c/web-platform-tests/preload/link-header-preload-imagesrcset.html Created attachment 371330 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Comment on attachment 371318 [details] Patch Attachment 371318 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12376675 New failing tests: imported/w3c/web-platform-tests/preload/link-header-preload-imagesrcset.html Created attachment 371332 [details]
Archive of layout-test-results from ews115 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 371318 [details] Patch Attachment 371318 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12376855 New failing tests: imported/w3c/web-platform-tests/preload/link-header-preload-imagesrcset.html Created attachment 371335 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 371382 [details]
Patch
Please make sure to upstream this one to WPT Right, these were added here: https://github.com/web-platform-tests/wpt/pull/17184/commits/d17788f09d86dda4be3f50d71ec836927c07c6f1 https://github.com/web-platform-tests/wpt/pull/17160/commits/fd4406194c91be1edb84054606aa7992533ab41d Comment on attachment 371382 [details] Patch Clearing flags on attachment: 371382 Committed r246629: <https://trac.webkit.org/changeset/246629> All reviewed patches have been landed. Closing bug. |