| Summary: | Improve performance of the lazy image loader | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jon Davis <jond> | ||||||
| Component: | WebKit Website | Assignee: | Jon Davis <jond> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ews-feeder, hi, jond, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jon Davis
2019-06-04 08:26:26 PDT
Created attachment 371285 [details]
Patch
Comment on attachment 371285 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371285&action=review r=me, neat! It may be worth a simple `if (window.IntersectionObserver)` check around (or as an early return in) `lazyLoadImages` so we don't throw an error if it's not supported. > Websites/webkit.org/ChangeLog:-101 > - I don't think we normally go back and edit ChangeLog entries, no matter how "bad" they may be. > Websites/webkit.org/wp-content/themes/webkit/scripts/global.js:-2 > - var openClass = ' open-menu', A comment explaining why this isn't needed would be nice :) > Websites/webkit.org/wp-content/themes/webkit/scripts/global.js:6 > + for (let table of tables) { Are we using `let` now??!? =D > Websites/webkit.org/wp-content/themes/webkit/scripts/global.js:22 > + if (backgroundImages.length == 0) NIT: you could use `!backgroundImages.length` instead Created attachment 371301 [details]
Patch
Comment on attachment 371301 [details] Patch Rejecting attachment 371301 [details] from review queue. jond@apple.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 371301 [details] Patch Clearing flags on attachment: 371301 Committed r246094: <https://trac.webkit.org/changeset/246094> All reviewed patches have been landed. Closing bug. |