Bug 198476

Summary: [Nicosia] Disable async scrolling until implemented
Product: WebKit Reporter: Zan Dobersek <zan>
Component: PlatformAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198475    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Zan Dobersek
Reported 2019-06-02 23:23:51 PDT
SSIA
Attachments
Patch (4.47 KB, patch)
2019-06-02 23:33 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.55 KB, patch)
2019-06-03 00:09 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.57 KB, patch)
2019-06-03 00:50 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.77 KB, patch)
2019-06-03 02:03 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2019-06-02 23:33:00 PDT
Created attachment 371177 [details] Patch
Antti Koivisto
Comment 2 2019-06-02 23:49:16 PDT
Comment on attachment 371177 [details] Patch Thanks!
Zan Dobersek
Comment 3 2019-06-03 00:09:31 PDT
Created attachment 371178 [details] Patch for landing Includes USE(COORDINATED_GRAPHICS) guard removal that should fix the GTK build ...
Zan Dobersek
Comment 4 2019-06-03 00:50:59 PDT
Created attachment 371179 [details] Patch for landing Try fixing iOS build ...
Zan Dobersek
Comment 5 2019-06-03 02:03:17 PDT
Created attachment 371182 [details] Patch for landing With updated ChangeLog entries.
Zan Dobersek
Comment 6 2019-06-03 02:45:53 PDT
Comment on attachment 371182 [details] Patch for landing Clearing flags on attachment: 371182 Committed r246033: <https://trac.webkit.org/changeset/246033>
Zan Dobersek
Comment 7 2019-06-03 02:45:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-06-03 02:46:19 PDT
<rdar://problem/51351478>
Simon Fraser (smfr)
Comment 9 2019-06-03 08:24:48 PDT
Comment on attachment 371182 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=371182&action=review > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:50 > +#if PLATFORM(IOS) || !ENABLE(ASYNC_SCROLLING) This should probably be IOS_FAMILY
Zan Dobersek
Comment 10 2019-06-03 08:35:46 PDT
(In reply to Simon Fraser (smfr) from comment #9) > Comment on attachment 371182 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371182&action=review > > > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:50 > > +#if PLATFORM(IOS) || !ENABLE(ASYNC_SCROLLING) > > This should probably be IOS_FAMILY Expanded in r246036. https://trac.webkit.org/changeset/246036/webkit
Note You need to log in before you can comment on or make changes to this bug.