Summary: | Memory-cached main resources continue to load after the client decides a content policy of PolicyAction::Download | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||||||||
Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, beidson, cdumez, dbates, ews-watchlist, ggaren, japhet, koivisto, rniwa, webkit-bug-importer, youennf | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Andy Estes
2019-06-02 15:47:38 PDT
Created attachment 371167 [details]
Patch
Comment on attachment 371167 [details] Patch Attachment 371167 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12358696 New failing tests: inspector/canvas/recording.html Created attachment 371171 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 371167 [details] Patch Attachment 371167 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12359257 New failing tests: svg/text/textpath-reference-update.html Created attachment 371174 [details]
Archive of layout-test-results from ews211 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 371167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371167&action=review > Source/WebCore/loader/DocumentLoader.cpp:953 > + ASSERT(m_mainResource); Is this assert needed given we check for m_mainResource at the beginning of the Download case block? As a side note, there is the case of substitute resource loads where we call mainReceivedError() in case of PolicyAction::Download. I wonder whether we should have consistent calls there. (In reply to youenn fablet from comment #8) > As a side note, there is the case of substitute resource loads where we call > mainReceivedError() in case of PolicyAction::Download. I wonder whether we > should have consistent calls there. stopLoadingForPolicyChange() calls mainReceivedError(), so I think we're consistent in that sense. It uses a different error code than in the call you cited ("interrupted for policy change" vs. "cannot show URL"), but I wanted to match the error code used in the call to ResourceLoader::didFail. (In reply to youenn fablet from comment #7) > Comment on attachment 371167 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371167&action=review > > > Source/WebCore/loader/DocumentLoader.cpp:953 > > + ASSERT(m_mainResource); > > Is this assert needed given we check for m_mainResource at the beginning of > the Download case block? I was curious to see if it could ever go missing after that check at the beginning, but I don't think it's needed. Will remove. Created attachment 371197 [details]
Patch
Comment on attachment 371197 [details] Patch Attachment 371197 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12364606 New failing tests: http/wpt/service-workers/service-worker-networkprocess-crash.html Created attachment 371202 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Committed r246043: <https://trac.webkit.org/changeset/246043> |