|Product:||WebKit||Reporter:||Fabian Jakobs <fabian.jakobs>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Fabian Jakobs 2008-07-01 07:23:29 PDT
Comment 1 Fabian Jakobs 2008-07-01 07:25:14 PDT
Created attachment 22028 [details] Test case for this bug Example which shows this problem. Other browser including Safari 3.1.1 return "true" while the current nightly returns "false"
Comment 3 Cameron Zwarich (cpst) 2008-07-01 16:19:32 PDT
Created attachment 22033 [details] Codegen dump The problem is that it is writing the result of stricteq to lr2, which is 'this'. I will fix this after dinner.
Comment 4 Cameron Zwarich (cpst) 2008-07-01 16:28:48 PDT
Created attachment 22034 [details] Proposed patch (without tests) Here's a patch. I will add tests to fast/js/codegen-temporaries for both the 'this' and local variable cases.
Comment 5 Darin Adler 2008-07-01 16:32:15 PDT
Comment on attachment 22034 [details] Proposed patch (without tests) Patch looks good. r=me But why not include the tests with the patch next time?
Comment 6 Cameron Zwarich (cpst) 2008-07-01 16:32:46 PDT
(In reply to comment #5) > (From update of attachment 22034 [details] ) > Patch looks good. r=me > > But why not include the tests with the patch next time? Going out for a Canada Day dinner and didn't have the time.
Comment 8 Fabian Jakobs 2008-07-02 01:19:50 PDT
Awesome. This was really quick! Works for me.