Bug 198423

Summary: [ Mac WK2 ] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky timeout when run locally.
Product: WebKit Reporter: Shawn Roberts <sroberts>
Component: WebKit APIAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jlewis3, rniwa, ryanhaddad, sihui_liu, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=198090
Attachments:
Description Flags
Patch
rniwa: review+
Patch none

Shawn Roberts
Reported 2019-05-31 10:02:05 PDT
The following API test is failing when run locally. TestWebKitAPI.WKWebView.LocalStorageProcessCrashes Test originally had originally landed in r244540 and was a flaky failure on the bots and when run locally. Test was fixed in r245649 and we have not seen any failures on the bots since this change. However when using my original repro to close out the bug/radar I noticed I get Timeouts on the test when run locally, using my original repro. Reproduced with: run-api-tests TestWebKitAPI.WKWebView.LocalStorageProcessCrashes --iter 30 Gets about 1 timeout in 10 runs. Test suite failed Timeout TestWebKitAPI.WKWebView.LocalStorageProcessCrashes _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
Attachments
Patch (3.63 KB, patch)
2019-05-31 14:48 PDT, Sihui Liu 		rniwa: review+
DetailsFormatted DiffDiff
Patch (2.18 KB, patch)
2019-05-31 23:02 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-05-31 10:02:48 PDT
<rdar://problem/51305247>
Sihui Liu
Comment 2 2019-05-31 14:48:17 PDT
Created attachment 371087 [details] Patch
Ryosuke Niwa
Comment 3 2019-05-31 17:23:15 PDT
Comment on attachment 371087 [details] Patch Looks sane to me. You probably want to explain what you told me in the change log so that others can follow what’s happening here.
Sihui Liu
Comment 4 2019-05-31 23:02:46 PDT
Created attachment 371108 [details] Patch
WebKit Commit Bot
Comment 5 2019-06-03 14:10:42 PDT
Comment on attachment 371108 [details] Patch Clearing flags on attachment: 371108 Committed r246050: <https://trac.webkit.org/changeset/246050>
WebKit Commit Bot
Comment 6 2019-06-03 14:10:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.