Bug 198423

Summary: [ Mac WK2 ] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky timeout when run locally.
Product: WebKit Reporter: Shawn Roberts <sroberts>
Component: WebKit APIAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jlewis3, rniwa, ryanhaddad, sihui_liu, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=198090
Attachments:
Description Flags
Patch
rniwa: review+
Patch none

Description Shawn Roberts 2019-05-31 10:02:05 PDT 
The following API test is failing when run locally.

TestWebKitAPI.WKWebView.LocalStorageProcessCrashes

Test originally had originally landed in r244540 and was a flaky failure on the bots and when run locally. Test was fixed in r245649 and we have not seen any failures on the bots since this change. However when using my original repro to close out the bug/radar I noticed I get Timeouts on the test when run locally, using my original repro. 

Reproduced with:

run-api-tests TestWebKitAPI.WKWebView.LocalStorageProcessCrashes --iter 30

Gets about 1 timeout in 10 runs.

Test suite failed

Timeout

    TestWebKitAPI.WKWebView.LocalStorageProcessCrashes
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
Comment 1 Radar WebKit Bug Importer 2019-05-31 10:02:48 PDT 
<rdar://problem/51305247>
Comment 2 Sihui Liu 2019-05-31 14:48:17 PDT 
Created attachment 371087 [details]
Patch
Comment 3 Ryosuke Niwa 2019-05-31 17:23:15 PDT 
Comment on attachment 371087 [details]
Patch

Looks sane to me. You probably want to explain what you told me in the change log so that others can follow what’s happening here.
Comment 4 Sihui Liu 2019-05-31 23:02:46 PDT 
Created attachment 371108 [details]
Patch
Comment 5 WebKit Commit Bot 2019-06-03 14:10:42 PDT 
Comment on attachment 371108 [details]
Patch

Clearing flags on attachment: 371108

Committed r246050: <https://trac.webkit.org/changeset/246050>
Comment 6 WebKit Commit Bot 2019-06-03 14:10:43 PDT 
All reviewed patches have been landed.  Closing bug.